From nobody Fri May 9 19:08:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1538489727422365.31304831592763; Tue, 2 Oct 2018 07:15:27 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92F611291; Tue, 2 Oct 2018 14:15:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D2A8611CF; Tue, 2 Oct 2018 14:15:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DF4424CA95; Tue, 2 Oct 2018 14:15:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w92EFFOC020293 for ; Tue, 2 Oct 2018 10:15:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9229C1C939; Tue, 2 Oct 2018 14:15:15 +0000 (UTC) Received: from kinshicho.redhat.com (unknown [10.40.205.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCD9C28D0B for ; Tue, 2 Oct 2018 14:15:14 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 2 Oct 2018 16:14:46 +0200 Message-Id: <20181002141446.20943-8-abologna@redhat.com> In-Reply-To: <20181002141446.20943-1-abologna@redhat.com> References: <20181002141446.20943-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [RFC 7/7] tools: Force virsh to use deprecated features X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 02 Oct 2018 14:15:26 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Instead of trying newer APIs first and only falling back to deprecated ones if those are not available, go straight for the older APIs. Running 'virsh list' will now cause warnings to be displayed. Signed-off-by: Andrea Bolognani --- tools/virsh-domain-monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 3a2636377d..f2f2944a8a 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -1609,6 +1609,8 @@ virshDomainListCollect(vshControl *ctl, unsigned int = flags) int mansave; virshControlPtr priv =3D ctl->privData; =20 + goto fallback; + /* try the list with flags support (0.9.13 and later) */ if ((ret =3D virConnectListAllDomains(priv->conn, &list->domains, flags)) >=3D 0) { --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list