Add ns to the node's children when setting a custom XML

[libvirt] [glib PATCH 0/2] Add ns to the node's children when setting a custom XML

Fabiano Fidêncio posted 2 patches 5 years, 6 months ago

Download series mbox

Failed in applying to current master (apply log)

libvirt-gconfig/libvirt-gconfig-domain.c      | 41 ++++++++++++---
libvirt-gconfig/libvirt-gconfig-domain.h      |  5 ++
.../libvirt-gconfig-object-private.h          |  3 +-
libvirt-gconfig/libvirt-gconfig-object.c      | 51 +++++++++++++++----
libvirt-gconfig/libvirt-gconfig.sym           |  5 ++
tests/test-gconfig.c                          |  3 ++
tests/xml/gconfig-domain.xml                  | 12 +++++
7 files changed, 103 insertions(+), 17 deletions(-)

Expand all Fold all

[libvirt] [glib PATCH 0/2] Add ns to the node's children when setting a custom XML

Posted by Fabiano Fidêncio 5 years, 6 months ago

This work is preparing the field for adding and using metadata.libosinfo
in GNOME Boxes (in a similar way that's already done for virt-manager)
so we can have a cross-app schema for tracking libosinfo OS ID in the
domain <metadata> XML.

The tests added are from real cases as:
- current Boxes' metadata (so, we ensure we won't break anything there);
- the new Boxes' metadata.libosinfo;
- Nova's XML example;

Fabiano Fidêncio (2):
  object: Also add the ns to the node's children
  domain: Introduce gvir_config_domain_set_custom_xml_ns_children()

 libvirt-gconfig/libvirt-gconfig-domain.c      | 41 ++++++++++++---
 libvirt-gconfig/libvirt-gconfig-domain.h      |  5 ++
 .../libvirt-gconfig-object-private.h          |  3 +-
 libvirt-gconfig/libvirt-gconfig-object.c      | 51 +++++++++++++++----
 libvirt-gconfig/libvirt-gconfig.sym           |  5 ++
 tests/test-gconfig.c                          |  3 ++
 tests/xml/gconfig-domain.xml                  | 12 +++++
 7 files changed, 103 insertions(+), 17 deletions(-)

-- 
2.19.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [glib PATCH 0/2] Add ns to the node's children when setting a custom XML

Posted by Michal Privoznik 5 years, 6 months ago

On 10/03/2018 01:59 PM, Fabiano Fidêncio wrote:
> This work is preparing the field for adding and using metadata.libosinfo
> in GNOME Boxes (in a similar way that's already done for virt-manager)
> so we can have a cross-app schema for tracking libosinfo OS ID in the
> domain <metadata> XML.
> 
> The tests added are from real cases as:
> - current Boxes' metadata (so, we ensure we won't break anything there);
> - the new Boxes' metadata.libosinfo;
> - Nova's XML example;
> 
> Fabiano Fidêncio (2):
>   object: Also add the ns to the node's children
>   domain: Introduce gvir_config_domain_set_custom_xml_ns_children()
> 
>  libvirt-gconfig/libvirt-gconfig-domain.c      | 41 ++++++++++++---
>  libvirt-gconfig/libvirt-gconfig-domain.h      |  5 ++
>  .../libvirt-gconfig-object-private.h          |  3 +-
>  libvirt-gconfig/libvirt-gconfig-object.c      | 51 +++++++++++++++----
>  libvirt-gconfig/libvirt-gconfig.sym           |  5 ++
>  tests/test-gconfig.c                          |  3 ++
>  tests/xml/gconfig-domain.xml                  | 12 +++++
>  7 files changed, 103 insertions(+), 17 deletions(-)
> 

ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list