[libvirt] [osinfo-db-tools PATCH v2 0/2] RFC: Make osinfo-db-import aware of URLs

Fabiano Fidêncio posted 2 patches 5 years, 6 months ago
Failed in applying to current master (apply log)
tools/osinfo-db-import.c | 91 ++++++++++++++++++++++++++++++++++++----
1 file changed, 84 insertions(+), 7 deletions(-)
[libvirt] [osinfo-db-tools PATCH v2 0/2] RFC: Make osinfo-db-import aware of URLs
Posted by Fabiano Fidêncio 5 years, 6 months ago
This is a simple draft of a work that has been discussed back in July as
part of this thread[0].

There are a few things which are not clear to me whether we want (or
whether we do *not* want).

For now I'm not using any progress callback to print the download status
and I don't even know whether it would be desired to have. But this is
something that could be easily done.

Also, for now the operation is synchronous and there's no cancellable
used ... but that's something that could be changed (although I don't
see the need for that right now).

In order to give it a try, please, just build our source with the patch
included and try:
./tools/osinfo-db-import https://releases.pagure.org/libosinfo/osinfo-db-20180920.tar.xz
./tools/osinfo-db-import https://foo.bar/foo.bar.tar.xz

[0]: https://www.redhat.com/archives/libosinfo/2018-July/msg00002.html

Changes since v1:
- Use Gio instead of curl;
- An additional patch removing a unused var;

Fabiano Fidêncio (2):
  import: Learn how to deal with URLs
  import: Remove unused variable

 tools/osinfo-db-import.c | 91 ++++++++++++++++++++++++++++++++++++----
 1 file changed, 84 insertions(+), 7 deletions(-)

-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [osinfo-db-tools PATCH v2 0/2] RFC: Make osinfo-db-import aware of URLs
Posted by Fabiano Fidêncio 5 years, 6 months ago
On Mon, 2018-10-08 at 10:53 +0200, Fabiano Fidêncio wrote:

> This is a simple draft of a work that has been discussed back in July
> as
> part of this thread[0].
> 
> There are a few things which are not clear to me whether we want (or
> whether we do *not* want).
> 
> For now I'm not using any progress callback to print the download
> status
> and I don't even know whether it would be desired to have. But this
> is
> something that could be easily done.
> 
> Also, for now the operation is synchronous and there's no cancellable
> used ... but that's something that could be changed (although I don't
> see the need for that right now).
> 
> In order to give it a try, please, just build our source with the
> patch
> included and try:
> ./tools/osinfo-db-import 
> https://releases.pagure.org/libosinfo/osinfo-db-20180920.tar.xz
> ./tools/osinfo-db-import https://foo.bar/foo.bar.tar.xz
> 
> [0]: 
> https://www.redhat.com/archives/libosinfo/2018-July/msg00002.html
> 
> Changes since v1:
> - Use Gio instead of curl;
> - An additional patch removing a unused var;
> 
> Fabiano Fidêncio (2):
>   import: Learn how to deal with URLs
>   import: Remove unused variable
> 
>  tools/osinfo-db-import.c | 91 ++++++++++++++++++++++++++++++++++++
> ----
>  1 file changed, 84 insertions(+), 7 deletions(-)
> 

Oops, please, ignore those patches as they've been sent to wrong list,
sorry for the noise!


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list