Series comparison

This RFC patch series introduces initial libvirt support for guest
dedicated crypto adapters on S390.
It essentially allows to specify a vfio-ap mediated device in a domain.
Extensive documentation about AP is available in patch 6 of
the QEMU patch series.

KVM/kernel: guest dedicated crypto adapters
https://lkml.org/lkml/2018/9/26/25

QEMU: s390x: vfio-ap: guest dedicated crypto adapters
https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03538.html

Boris Fiuczynski (3):
  qemu: add vfio-ap capability
  qemu: vfio-ap device support
  news: Update news for vfio-ap support

-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Introduce vfio-ap capability.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
---
 src/qemu/qemu_capabilities.c | 2 ++
 src/qemu/qemu_capabilities.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index XXXXXXX..XXXXXXX 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -XXX,XX +XXX,XX @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
               /* 315 */
               "vfio-pci.display",
               "blockdev",
+              "vfio-ap",
     );
 
 
@@ -XXX,XX +XXX,XX @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = {
     { "vhost-vsock-device", QEMU_CAPS_DEVICE_VHOST_VSOCK },
     { "mch", QEMU_CAPS_DEVICE_MCH },
     { "sev-guest", QEMU_CAPS_SEV_GUEST },
+    { "vfio-ap", QEMU_CAPS_DEVICE_VFIO_AP },
 };
 
 static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVirtioBalloon[] = {
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index XXXXXXX..XXXXXXX 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -XXX,XX +XXX,XX @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
     /* 315 */
     QEMU_CAPS_VFIO_PCI_DISPLAY, /* -device vfio-pci.display */
     QEMU_CAPS_BLOCKDEV, /* -blockdev and blockdev-add are supported */
+    QEMU_CAPS_DEVICE_VFIO_AP, /* -device vfio-ap */
 
     QEMU_CAPS_LAST /* this must always be the last item */
 } virQEMUCapsFlags;
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Adjusting domain format documentation, adding device address
support and adding command line generation for vfio-ap.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
---
 docs/formatdomain.html.in | 3 ++-
 docs/schemas/domaincommon.rng | 1 +
 src/qemu/qemu_command.c | 8 ++++++++
 src/qemu/qemu_domain_address.c | 4 ++++
 src/util/virmdev.c | 3 ++-
 src/util/virmdev.h | 1 +
 6 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index XXXXXXX..XXXXXXX 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -XXX,XX +XXX,XX @@
 <dd>For mediated devices (Since 3.2.0)
 the <code>model</code> attribute specifies the device API which
 determines how the host's vfio driver will expose the device to the
- guest. Currently, <code>model='vfio-pci'</code> and
+ guest. Currently, <code>model='vfio-pci'</code>,
 <code>model='vfio-ccw'</code> (Since 4.4.0)
+ and <code>model='vfio-ap'</code> (Since 4.9.0)
 is supported. <a href="drvnodedev.html#MDEV">MDEV</a> section
 provides more information about mediated devices as well as how to
 create mediated devices on the host.
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index XXXXXXX..XXXXXXX 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -XXX,XX +XXX,XX @@
 <choice>
 <value>vfio-pci</value>
 <value>vfio-ccw</value>
+ <value>vfio-ap</value>
 </choice>
 </attribute>
 <optional>
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index XXXXXXX..XXXXXXX 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -XXX,XX +XXX,XX @@ qemuBuildHostdevCommandLine(virCommandPtr cmd,
 return -1;
 }
 break;
+ case VIR_MDEV_MODEL_TYPE_VFIO_AP:
+ if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VFIO_AP)) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+ _("VFIO AP device assignment is not "
+ "supported by this version of QEMU"));
+ return -1;
+ }
+ break;
 case VIR_MDEV_MODEL_TYPE_LAST:
 default:
 virReportEnumRangeError(virMediatedDeviceModelType,
diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index XXXXXXX..XXXXXXX 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -XXX,XX +XXX,XX @@ qemuDomainPrimeVfioDeviceAddresses(virDomainDefPtr def,
 subsys->u.mdev.model == VIR_MDEV_MODEL_TYPE_VFIO_CCW &&
 def->hostdevs[i]->info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE)
 def->hostdevs[i]->info->type = type;
+
+ if (virHostdevIsMdevDevice(def->hostdevs[i]) &&
+ subsys->u.mdev.model == VIR_MDEV_MODEL_TYPE_VFIO_AP)
+ def->hostdevs[i]->info->type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE;
 }
 }
 
diff --git a/src/util/virmdev.c b/src/util/virmdev.c
index XXXXXXX..XXXXXXX 100644
--- a/src/util/virmdev.c
+++ b/src/util/virmdev.c
@@ -XXX,XX +XXX,XX @@ struct _virMediatedDeviceList {
 
 VIR_ENUM_IMPL(virMediatedDeviceModel, VIR_MDEV_MODEL_TYPE_LAST,
 "vfio-pci",
- "vfio-ccw")
+ "vfio-ccw",
+ "vfio-ap")
 
 static virClassPtr virMediatedDeviceListClass;
 
diff --git a/src/util/virmdev.h b/src/util/virmdev.h
index XXXXXXX..XXXXXXX 100644
--- a/src/util/virmdev.h
+++ b/src/util/virmdev.h
@@ -XXX,XX +XXX,XX @@
 typedef enum {
 VIR_MDEV_MODEL_TYPE_VFIO_PCI = 0,
 VIR_MDEV_MODEL_TYPE_VFIO_CCW = 1,
+ VIR_MDEV_MODEL_TYPE_VFIO_AP = 2,
 
 VIR_MDEV_MODEL_TYPE_LAST
 } virMediatedDeviceModelType;
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

This patch series introduces initial libvirt support for guest
dedicated crypto adapters on S390.
It allows to specify a vfio-ap mediated device in a domain.
Extensive documentation about AP is available in patch 6 of
the QEMU patch series.

KVM/kernel: guest dedicated crypto adapters
https://lkml.org/lkml/2018/9/26/25

QEMU: s390x: vfio-ap: guest dedicated crypto adapters
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01993.html

The qemu patch series has been included into master.
https://git.qemu.org/?p=qemu.git;a=commit;h=69ac8c4cb93f2685839ff7b857cef306b388ff3c

Boris Fiuczynski (3):
  qemu: add vfio-ap capability
  qemu: vfio-ap device support
  news: Update news for vfio-ap support

-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Introduce vfio-ap capability.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.ibm.com>
---
 src/qemu/qemu_capabilities.c | 2 ++
 src/qemu/qemu_capabilities.h | 1 +
 2 files changed, 3 insertions(+)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Adjusting domain format documentation, adding device address
support and adding command line generation for vfio-ap.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.ibm.com>
---
 docs/formatdomain.html.in | 3 ++-
 docs/schemas/domaincommon.rng | 1 +
 src/qemu/qemu_command.c | 8 ++++++++
 src/qemu/qemu_domain_address.c | 4 ++++
 src/util/virmdev.c | 3 ++-
 src/util/virmdev.h | 1 +
 6 files changed, 18 insertions(+), 2 deletions(-)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list