From nobody Sat Apr 20 01:35:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1539096221501466.2192845457563; Tue, 9 Oct 2018 07:43:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C175688317; Tue, 9 Oct 2018 14:43:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7954E6F4F9; Tue, 9 Oct 2018 14:43:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1DA74180474F; Tue, 9 Oct 2018 14:43:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w99EhbsR015411 for ; Tue, 9 Oct 2018 10:43:37 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9E40577BEA; Tue, 9 Oct 2018 14:43:37 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.40.205.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id F33B06A96F for ; Tue, 9 Oct 2018 14:43:33 +0000 (UTC) From: Katerina Koukiou To: libvir-list@redhat.com Date: Tue, 9 Oct 2018 16:43:31 +0200 Message-Id: <20181009144331.27152-1-kkoukiou@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH] maint: fix compiler errors for FreeBSD X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 09 Oct 2018 14:43:40 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We were facing such errors: * error: unused function 'glib_slistautoptr_cleanup_virtDBusConnect Moving the G_DEFINE_AUTOPTR_CLEANUP_FUNC macros in the header files fixes the issue. Signed-off-by: Katerina Koukiou Reviewed-by: J=EF=BF=BDn Tomko --- src/connect.c | 3 +-- src/connect.h | 5 +++++ src/network.c | 4 +--- src/network.h | 6 ++++++ 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/connect.c b/src/connect.c index f0da1dd..f8f76a2 100644 --- a/src/connect.c +++ b/src/connect.c @@ -1995,7 +1995,7 @@ static virtDBusGDBusMethodTable virtDBusConnectMethod= Table[] =3D { =20 static GDBusInterfaceInfo *interfaceInfo =3D NULL; =20 -static void +void virtDBusConnectFree(virtDBusConnect *connect) { if (connect->connection) @@ -2011,7 +2011,6 @@ virtDBusConnectFree(virtDBusConnect *connect) g_free(connect->storageVolPath); g_free(connect); } -G_DEFINE_AUTOPTR_CLEANUP_FUNC(virtDBusConnect, virtDBusConnectFree); =20 void virtDBusConnectNew(virtDBusConnect **connectp, diff --git a/src/connect.h b/src/connect.h index 961b115..829bd57 100644 --- a/src/connect.h +++ b/src/connect.h @@ -44,3 +44,8 @@ virtDBusConnectOpen(virtDBusConnect *connect, =20 void virtDBusConnectListFree(virtDBusConnect **connectList); + +void +virtDBusConnectFree(virtDBusConnect *connect); + +G_DEFINE_AUTOPTR_CLEANUP_FUNC(virtDBusConnect, virtDBusConnectFree); diff --git a/src/network.c b/src/network.c index f3d5472..95ecdc7 100644 --- a/src/network.c +++ b/src/network.c @@ -3,7 +3,7 @@ =20 #include =20 -static void +void virtDBusNetworkDHCPLeaseListFree(virNetworkDHCPLeasePtr *leases) { for (gint i =3D 0; leases[i] !=3D NULL; i++) @@ -12,8 +12,6 @@ virtDBusNetworkDHCPLeaseListFree(virNetworkDHCPLeasePtr *= leases) g_free(leases); } =20 -G_DEFINE_AUTOPTR_CLEANUP_FUNC(virNetworkDHCPLeasePtr, virtDBusNetworkDHCPL= easeListFree); - static virNetworkPtr virtDBusNetworkGetVirNetwork(virtDBusConnect *connect, const gchar *objectPath, diff --git a/src/network.h b/src/network.h index fc53b28..0012585 100644 --- a/src/network.h +++ b/src/network.h @@ -1,9 +1,15 @@ #pragma once =20 #include "connect.h" +#include =20 #define VIRT_DBUS_NETWORK_INTERFACE "org.libvirt.Network" =20 void virtDBusNetworkRegister(virtDBusConnect *connect, GError **error); + +void +virtDBusNetworkDHCPLeaseListFree(virNetworkDHCPLeasePtr *leases); + +G_DEFINE_AUTOPTR_CLEANUP_FUNC(virNetworkDHCPLeasePtr, virtDBusNetworkDHCPL= easeListFree); --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list