conf: Fix typos in pcie controllers' name

[libvirt] [PATCH] conf: Fix typos in pcie controllers' name

Posted by Han Han 5 years, 6 months ago

Signed-off-by: Han Han <hhan@redhat.com>
---
 src/conf/domain_addr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index 442e6aab94..e4ed143b76 100644
--- a/src/conf/domain_addr.c
+++ b/src/conf/domain_addr.c
@@ -158,9 +158,9 @@ virDomainPCIAddressFlagsCompatible(virPCIDeviceAddressPtr addr,
         } else if (devFlags & VIR_PCI_CONNECT_TYPE_PCIE_ROOT_PORT) {
             connectStr = "pcie-root-port";
         } else if (devFlags & VIR_PCI_CONNECT_TYPE_PCIE_SWITCH_UPSTREAM_PORT) {
-            connectStr = "pci-switch-upstream-port";
+            connectStr = "pcie-switch-upstream-port";
         } else if (devFlags & VIR_PCI_CONNECT_TYPE_PCIE_SWITCH_DOWNSTREAM_PORT) {
-            connectStr = "pci-switch-downstream-port";
+            connectStr = "pcie-switch-downstream-port";
         } else if (devFlags & VIR_PCI_CONNECT_TYPE_DMI_TO_PCI_BRIDGE) {
             connectStr = "dmi-to-pci-bridge";
         } else if (devFlags & VIR_PCI_CONNECT_TYPE_PCIE_TO_PCI_BRIDGE) {
-- 
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: Fix typos in pcie controllers' name

Posted by Andrea Bolognani 5 years, 6 months ago

On Wed, 2018-10-17 at 09:10 +0800, Han Han wrote:
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  src/conf/domain_addr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
> index 442e6aab94..e4ed143b76 100644
> --- a/src/conf/domain_addr.c
> +++ b/src/conf/domain_addr.c
> @@ -158,9 +158,9 @@ virDomainPCIAddressFlagsCompatible(virPCIDeviceAddressPtr addr,
>          } else if (devFlags & VIR_PCI_CONNECT_TYPE_PCIE_ROOT_PORT) {
>              connectStr = "pcie-root-port";
>          } else if (devFlags & VIR_PCI_CONNECT_TYPE_PCIE_SWITCH_UPSTREAM_PORT) {
> -            connectStr = "pci-switch-upstream-port";
> +            connectStr = "pcie-switch-upstream-port";
>          } else if (devFlags & VIR_PCI_CONNECT_TYPE_PCIE_SWITCH_DOWNSTREAM_PORT) {
> -            connectStr = "pci-switch-downstream-port";
> +            connectStr = "pcie-switch-downstream-port";
>          } else if (devFlags & VIR_PCI_CONNECT_TYPE_DMI_TO_PCI_BRIDGE) {
>              connectStr = "dmi-to-pci-bridge";
>          } else if (devFlags & VIR_PCI_CONNECT_TYPE_PCIE_TO_PCI_BRIDGE) {

Good catch!

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and pushed :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list