[libvirt] [PATCH v4 27/37] qemu_process: Stop locking QMP process monitor immediately

Chris Venteicher posted 37 patches 5 years, 10 months ago
[libvirt] [PATCH v4 27/37] qemu_process: Stop locking QMP process monitor immediately
Posted by Chris Venteicher 5 years, 10 months ago
Locking the monitor object immediately after call to qemuMonitorOpen
doesn't make sense now that we have expanded the QEMU process code to
cover more than the original capabilities usecase.

Removing the monitor lock makes the qemuConnectMonitorQmp code
consistent with the qemuConnectMonitor code used to establish the
monitor when QEMU process is started for domains.

Signed-off-by: Chris Venteicher <cventeic@redhat.com>
---
 src/qemu/qemu_process.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 08522a1580..6bd3da97ca 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8297,8 +8297,6 @@ qemuConnectMonitorQmp(qemuProcessPtr proc)
 
     VIR_STEAL_PTR(proc->mon, mon);
 
-    virObjectLock(proc->mon);
-
     /* Exit capabilities negotiation mode and enter QEMU command mode
      * by issuing qmp_capabilities command to QEMU */
     if (qemuMonitorSetCapabilities(proc->mon) < 0) {
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list