From nobody Tue Jul 15 05:41:04 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1671190373; cv=none; d=zohomail.com; s=zohoarc; b=krKJRj326+1Km64LzLMSBwPNXG+ztt4QbH39+4MiwEIoi8bFDG0thiIHvCwGSn313DMOchLNZbWVxc1Akv3rsLkYdnplumWOFqv/QdjBQx/E0lyTZCUiJ+VsGWN5e1N+VA+NMjsjBdBsEF2TAF9LxroI1yFSX9mIPnslbi2M4cM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671190373; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OZQY1cbGTgb6aJq4nJ31VqYD0d7SkyMcwnHXTi/tH08=; b=PnEwik3Cd//KUDNVWnUdglv+WAuCGOWrO24W3iz6NeellNA+CbsNqhxaIikEW4cK2AZXejidjbNor/8/rO+8OmKDVqge2AuobBY5FviZI8cj92pzE9fT7cWYqAx42ESMzhYnFZ9I9/SJVGMidnsFptpBK7ZauwuM+ebfJIZpMaw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16711903739704.123338346040555; Fri, 16 Dec 2022 03:32:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p68wZ-0002DW-Ld; Fri, 16 Dec 2022 06:31:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p68wX-0002Cy-Oh for qemu-devel@nongnu.org; Fri, 16 Dec 2022 06:31:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p68wW-0008Ke-EX for qemu-devel@nongnu.org; Fri, 16 Dec 2022 06:31:57 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-606-Y_-TozZiPCSnzmWj7c1mVw-1; Fri, 16 Dec 2022 06:31:53 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6AF25858F0E; Fri, 16 Dec 2022 11:31:53 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DF97400F5A; Fri, 16 Dec 2022 11:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671190315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OZQY1cbGTgb6aJq4nJ31VqYD0d7SkyMcwnHXTi/tH08=; b=Zru4kWlPfLA0YSpo/ibhfHv3EouUkazfnNe+TUvR+XylXHGoKansFVu4Jgaf7cWAMOYJM5 F2HdgaaM/LNL9CSIDs4lT5iqUgBE+7Rbcum68Eph+Odh5HsTWw5bQG89szfdlU9ebqe29q OKgQ8Rs0iaBl78zz0UI6fiCSeVhYUC0= X-MC-Unique: Y_-TozZiPCSnzmWj7c1mVw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Paolo Bonzini , Hanna Reitz , qemu-block@nongnu.org, Peter Lieven , Kevin Wolf , libvir-list@redhat.com, Ronnie Sahlberg , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Markus Armbruster Subject: [PATCH v2 1/3] block: mention 'password-secret' option for -iscsi Date: Fri, 16 Dec 2022 06:31:50 -0500 Message-Id: <20221216113152.584460-2-berrange@redhat.com> In-Reply-To: <20221216113152.584460-1-berrange@redhat.com> References: <20221216113152.584460-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1671190376079100005 The 'password-secret' option was added commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrang=C3=A9 Date: Thu Jan 21 14:19:21 2016 +0000 iscsi: add support for getting CHAP password via QCryptoSecret API but was not mentioned in the command line docs Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Fabiano Rosas --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 7f99d15b23..58efb58072 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1889,8 +1889,8 @@ SRST ERST =20 DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi, - "-iscsi [user=3Duser][,password=3Dpassword]\n" - " [,header-digest=3DCRC32C|CR32C-NONE|NONE-CRC32C|NONE\n" + "-iscsi [user=3Duser][,password=3Dpassword][,password-secret=3Dsecret-= id]\n" + " [,header-digest=3DCRC32C|CR32C-NONE|NONE-CRC32C|NONE]\n" " [,initiator-name=3Dinitiator-iqn][,id=3Dtarget-iqn]\n" " [,timeout=3Dtimeout]\n" " iSCSI session parameters\n", QEMU_ARCH_ALL) --=20 2.38.1