From nobody Wed May 14 10:48:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 152466970828768.22292756445256; Wed, 25 Apr 2018 08:21:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBA65883BC; Wed, 25 Apr 2018 15:21:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D6463133BE0; Wed, 25 Apr 2018 15:21:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EDD57180BAD9; Wed, 25 Apr 2018 15:21:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3PFG4MC020170 for ; Wed, 25 Apr 2018 11:16:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0CA8D2024CA4; Wed, 25 Apr 2018 15:16:04 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 690A9202323B; Wed, 25 Apr 2018 15:16:03 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 25 Apr 2018 17:15:20 +0200 Message-Id: <2de2db4e9795c5d51049c093d925b65de5ca6c2b.1524668969.git.pkrempa@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Kevin Wolf , Peter Krempa Subject: [libvirt] [PATCH 12/35] qemu: domain: Store whether a virStorageSource is a host CDROM drive X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 25 Apr 2018 15:21:46 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Use virFileIsCdrom to detect whether a block device is a cdrom drive and store it in virStorageSource. This will be necessary to correctly create the 'host_cdrom' backend in qemu when using -blockdev. We assume that host_cdrom makes only sense when used directly as a raw image, but if a backing chain would be put in front of it, libvirt will use 'host_device' in that case. Signed-off-by: Peter Krempa Reviewed-by: John Ferlan --- src/qemu/qemu_domain.c | 8 ++++++++ src/util/virstoragefile.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 9f94809fd1..86e40e13e0 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -7545,6 +7545,14 @@ qemuDomainDetermineDiskChain(virQEMUDriverPtr driver, VIR_ALLOC(src->backingStore) < 0) goto cleanup; + /* host cdrom requires special treatment in qemu, so we need to ch= eck + * whether a block device is a cdrom */ + if (disk->device =3D=3D VIR_DOMAIN_DISK_DEVICE_CDROM && + src->format =3D=3D VIR_STORAGE_FILE_RAW && + virStorageSourceIsBlockLocal(src) && + virFileIsCdrom(src->path) =3D=3D 1) + src->hostcdrom =3D true; + ret =3D 0; goto cleanup; } diff --git a/src/util/virstoragefile.h b/src/util/virstoragefile.h index 57d39f98c2..c8a4a288b1 100644 --- a/src/util/virstoragefile.h +++ b/src/util/virstoragefile.h @@ -316,6 +316,8 @@ struct _virStorageSource { bool floppyimg; /* set to true if the storage source is going to be us= ed as a source for floppy drive */ + + bool hostcdrom; /* backing device is a cdrom */ }; --=20 2.16.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list