From nobody Tue Dec 16 08:36:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1519396096876274.46742399745176; Fri, 23 Feb 2018 06:28:16 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 59FB5F571D; Fri, 23 Feb 2018 14:28:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 28BC7508F4; Fri, 23 Feb 2018 14:28:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E55A94A482; Fri, 23 Feb 2018 14:28:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1NERs5H000323 for ; Fri, 23 Feb 2018 09:27:54 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5742E9C04F; Fri, 23 Feb 2018 14:27:54 +0000 (UTC) Received: from dnr.brq.redhat.com (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id F26A09C04C for ; Fri, 23 Feb 2018 14:27:53 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Fri, 23 Feb 2018 15:27:40 +0100 Message-Id: <36b86e0f03e89b2d8fc3e39577a0c81015951891.1519395939.git.jtomko@redhat.com> In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 14/16] vboxDumpNetwork: use a switch for attachmentType X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 23 Feb 2018 14:28:16 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: J=C3=A1n Tomko --- src/vbox/vbox_common.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 2943c534d..8f5f04efb 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -3707,11 +3707,13 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter= *adapter) return NULL; =20 gVBoxAPI.UINetworkAdapter.GetAttachmentType(adapter, &attachmentType); - if (attachmentType =3D=3D NetworkAttachmentType_NAT) { =20 + switch (attachmentType) { + case NetworkAttachmentType_NAT: net->type =3D VIR_DOMAIN_NET_TYPE_USER; + break; =20 - } else if (attachmentType =3D=3D NetworkAttachmentType_Bridged) { + case NetworkAttachmentType_Bridged: net->type =3D VIR_DOMAIN_NET_TYPE_BRIDGE; =20 gVBoxAPI.UINetworkAdapter.GetBridgedInterface(adapter, &utf16); @@ -3721,8 +3723,9 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *= adapter) =20 VBOX_UTF8_FREE(utf8); VBOX_UTF16_FREE(utf16); + break; =20 - } else if (attachmentType =3D=3D NetworkAttachmentType_Internal) { + case NetworkAttachmentType_Internal: net->type =3D VIR_DOMAIN_NET_TYPE_INTERNAL; =20 gVBoxAPI.UINetworkAdapter.GetInternalNetwork(adapter, &utf16); @@ -3732,8 +3735,9 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *= adapter) =20 VBOX_UTF8_FREE(utf8); VBOX_UTF16_FREE(utf16); + break; =20 - } else if (attachmentType =3D=3D NetworkAttachmentType_HostOnly) { + case NetworkAttachmentType_HostOnly: net->type =3D VIR_DOMAIN_NET_TYPE_NETWORK; =20 gVBoxAPI.UINetworkAdapter.GetHostOnlyInterface(adapter, &utf16); @@ -3743,8 +3747,9 @@ vboxDumpNetwork(vboxDriverPtr data, INetworkAdapter *= adapter) =20 VBOX_UTF8_FREE(utf8); VBOX_UTF16_FREE(utf16); + break; =20 - } else { + default: /* default to user type i.e. NAT in VirtualBox if this * dump is ever used to create a machine. */ --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list