Commit 70255fa5 introduced a double space before the newline-escaping
backslash and broke syntax check.
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
Pushed as a trivial build-breaker fix.
tests/qemuxml2argvtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 43f07efc1..509fe776e 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -668,7 +668,7 @@ mymain(void)
testCompareXMLToArgv, &info) < 0) \
ret = -1; \
if (virTestRun("QEMU XML-2-startup-XML " name, \
- testCompareXMLToStartupXML, &info) < 0) \
+ testCompareXMLToStartupXML, &info) < 0) \
ret = -1; \
virObjectUnref(info.qemuCaps); \
virObjectUnref(info.vm); \
--
2.16.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Apr 17, 2018 at 02:02:54PM +0200, Ján Tomko wrote: >Commit 70255fa5 introduced a double space before the newline-escaping >backslash and broke syntax check. > >Signed-off-by: Ján Tomko <jtomko@redhat.com> >--- >Pushed as a trivial build-breaker fix. > > tests/qemuxml2argvtest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks for the fix, I confirmed *again* that I have `c-auto-align-backslashes` set to `nil`, so this should not happen more than like last three or four times. >diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c >index 43f07efc1..509fe776e 100644 >--- a/tests/qemuxml2argvtest.c >+++ b/tests/qemuxml2argvtest.c >@@ -668,7 +668,7 @@ mymain(void) > testCompareXMLToArgv, &info) < 0) \ > ret = -1; \ > if (virTestRun("QEMU XML-2-startup-XML " name, \ >- testCompareXMLToStartupXML, &info) < 0) \ >+ testCompareXMLToStartupXML, &info) < 0) \ > ret = -1; \ > virObjectUnref(info.qemuCaps); \ > virObjectUnref(info.vm); \ >-- >2.16.1 > >-- >libvir-list mailing list >libvir-list@redhat.com >https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Apr 17, 2018 at 14:38:31 +0200, Martin Kletzander wrote: > On Tue, Apr 17, 2018 at 02:02:54PM +0200, Ján Tomko wrote: > > Commit 70255fa5 introduced a double space before the newline-escaping > > backslash and broke syntax check. > > > > Signed-off-by: Ján Tomko <jtomko@redhat.com> > > --- > > Pushed as a trivial build-breaker fix. > > > > tests/qemuxml2argvtest.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Thanks for the fix, I confirmed *again* that I have `c-auto-align-backslashes` > set to `nil`, so this should not happen more than like last three or four times. I'd suggest actually running syntax-check prior to pushing ... -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2025 Red Hat, Inc.