From nobody Wed May 14 13:28:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1522071251474212.1301495716923; Mon, 26 Mar 2018 06:34:11 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 096FC7F7A5; Mon, 26 Mar 2018 13:34:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FC5F5E9D0; Mon, 26 Mar 2018 13:34:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 32095181BA05; Mon, 26 Mar 2018 13:34:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2QDXuYO014232 for ; Mon, 26 Mar 2018 09:33:56 -0400 Received: by smtp.corp.redhat.com (Postfix) id 09739215CDB5; Mon, 26 Mar 2018 13:33:56 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3FF0215CDAE for ; Mon, 26 Mar 2018 13:33:55 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 26 Mar 2018 15:33:51 +0200 Message-Id: <3c2b77c3571d5efcab98240d89c4d2edda597e04.1522071186.git.phrdina@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 2/4] spec: cleanup spec file based on fedora package review X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 26 Mar 2018 13:34:10 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" All of these changes are simple enough so I've put the into single commit: - remove obsolete tags and commands - %global macro is preferred over %define macro - use %autosetup, %make_build and %make_install macros - COPYING file should be listed using %license macro Signed-off-by: Pavel Hrdina --- libvirt-dbus.spec.in | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/libvirt-dbus.spec.in b/libvirt-dbus.spec.in index 3a04ad6..4b8e752 100644 --- a/libvirt-dbus.spec.in +++ b/libvirt-dbus.spec.in @@ -1,19 +1,17 @@ # -*- rpm-spec -*- =20 -%define glib2_version @GLIB2_REQUIRED@ -%define libvirt_version @LIBVIRT_REQUIRED@ -%define libvirt_glib_version @LIBVIRT_GLIB_REQUIRED@ -%define system_user @SYSTEM_USER@ +%global glib2_version @GLIB2_REQUIRED@ +%global libvirt_version @LIBVIRT_REQUIRED@ +%global libvirt_glib_version @LIBVIRT_GLIB_REQUIRED@ +%global system_user @SYSTEM_USER@ =20 Name: @PACKAGE@ Version: @VERSION@ -Release: 1%{?dist}%{?extra_release} +Release: 1%{?dist} Summary: libvirt dbus API binding -Group: Development/Libraries License: LGPLv2+ URL: https://libvirt.org/ Source0: https://libvirt.org/sources/dbus/%{name}-%{version}.tar.gz -BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) =20 BuildRequires: gcc BuildRequires: glib2-devel >=3D %{glib2_version} @@ -30,18 +28,14 @@ Requires(pre): shadow-utils This package provides integration between libvirt and the DBus =20 %prep -%setup -q +%autosetup =20 %build %configure -%__make %{?_smp_mflags} +%make_build =20 %install -rm -rf $RPM_BUILD_ROOT -%__make install DESTDIR=3D$RPM_BUILD_ROOT - -%clean -rm -rf $RPM_BUILD_ROOT +%make_install =20 %pre getent group %{system_user} >/dev/null || groupadd -r %{system_user} @@ -51,8 +45,8 @@ getent passwd %{system_user} >/dev/null || \ exit 0 =20 %files -%defattr(-,root,root,-) -%doc README.md HACKING.md COPYING NEWS +%doc README.md HACKING.md NEWS +%license COPYING %{_sysconfdir}/polkit-1/rules.d/libvirt-dbus.rules %{_bindir}/libvirt-dbus %{_datadir}/dbus-1/services/org.libvirt.service --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list