qemu: Fix memory leak in qemuDomainBlockJobSetSpeed()

[libvirt] [PATCH] qemu: Fix memory leak in qemuDomainBlockJobSetSpeed()

w00251574 posted 1 patch 5 years, 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/3cd477f3-c06e-4866-83a8-f3ee696bca6f@HGHY1w002515742.local

Test syntax-check passed

src/qemu/qemu_driver.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[libvirt] [PATCH] qemu: Fix memory leak in qemuDomainBlockJobSetSpeed()

Posted by w00251574 5 years, 10 months ago

Subject: [PATCH] qemu: Fix memory leak in qemuDomainBlockJobSetSpeed()

fix 'device' leak in qemuDomainBlockJobSetSpeed

Signed-off-by: Jie Wang <wangjie88.huawei.com>
---
 src/qemu/qemu_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 921aafcd79..b45c26eb3b 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17395,6 +17395,7 @@ qemuDomainBlockJobSetSpeed(virDomainPtr dom,
     qemuDomainObjEndJob(driver, vm);
 
  cleanup:
+    VIR_FREE(device);
     virDomainObjEndAPI(&vm);
 
     return ret;
-- 
2.15.0.windows.1




--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Fix memory leak in qemuDomainBlockJobSetSpeed()

Posted by Michal Prívozník 5 years, 10 months ago

On 06/25/2018 04:15 PM, w00251574 wrote:
> Subject: [PATCH] qemu: Fix memory leak in qemuDomainBlockJobSetSpeed()
> 
> fix 'device' leak in qemuDomainBlockJobSetSpeed
> 
> Signed-off-by: Jie Wang <wangjie88.huawei.com>
> ---
>  src/qemu/qemu_driver.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 921aafcd79..b45c26eb3b 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -17395,6 +17395,7 @@ qemuDomainBlockJobSetSpeed(virDomainPtr dom,
>      qemuDomainObjEndJob(driver, vm);
>  
>   cleanup:
> +    VIR_FREE(device);
>      virDomainObjEndAPI(&vm);
>  
>      return ret;
> 

Almost. @device is type of 'const char *' and that needs to change (one
should never free a const string). Secondly, with this change there are
multiple ways to get to @cleanup label without @device being set to
anything (and thus we might end up freeing random pointer).

Fixed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list