From nobody Tue Feb 10 07:51:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1527841221884116.6812429262435; Fri, 1 Jun 2018 01:20:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 345A230BFD76; Fri, 1 Jun 2018 08:20:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E870C60BE3; Fri, 1 Jun 2018 08:20:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 944CC18033EE; Fri, 1 Jun 2018 08:20:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w518KILU028659 for ; Fri, 1 Jun 2018 04:20:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 179722166BB6; Fri, 1 Jun 2018 08:20:18 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD7A92166BB2 for ; Fri, 1 Jun 2018 08:20:17 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Fri, 1 Jun 2018 10:19:58 +0200 Message-Id: <50dc45175ba6b29e867d4b7013c80260d237269f.1527841021.git.pkrempa@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [RFC PATCH 6/9] tests: qemucapsprobemock: Prepare 'qemucapsprobe' for the new format X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 01 Jun 2018 08:20:20 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Change the output of qemucapsprobe to record the commands used for querying. This allows to easily identify which reply belongs to which command and also will allow to test whether we use stable queries. This change includes changing dropping of the QMP greeting from the file and reformatting of the query and output to stdout. Signed-off-by: Peter Krempa --- tests/qemucapsprobemock.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/tests/qemucapsprobemock.c b/tests/qemucapsprobemock.c index a0d2acb69a..5936975505 100644 --- a/tests/qemucapsprobemock.c +++ b/tests/qemucapsprobemock.c @@ -37,6 +37,7 @@ } \ } while (0) +static bool first =3D true; static void printLineSkipEmpty(const char *line, @@ -60,9 +61,22 @@ int qemuMonitorSend(qemuMonitorPtr mon, qemuMonitorMessagePtr msg) { + char *reformatted; + REAL_SYM(realQemuMonitorSend); - fprintf(stderr, "%s", msg->txBuffer); + if (!(reformatted =3D virJSONStringReformat(msg->txBuffer, true))) { + fprintf(stderr, "Failed to reformat command string '%s'\n", msg->t= xBuffer); + abort(); + } + + if (first) + first =3D false; + else + printLineSkipEmpty("\n", stdout); + + printLineSkipEmpty(reformatted, stdout); + VIR_FREE(reformatted); return realQemuMonitorSend(mon, msg); } @@ -77,7 +91,6 @@ qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon, const char *line, qemuMonitorMessagePtr msg) { - static bool first =3D true; virJSONValuePtr value =3D NULL; char *json =3D NULL; int ret; @@ -93,14 +106,14 @@ qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon, abort(); } - if (first) { + /* Ignore QMP greeting */ + if (virJSONValueObjectHasKey(value, "QMP")) + goto cleanup; + + if (first) first =3D false; - } else { - /* Ignore QMP greeting if it's not the first one */ - if (virJSONValueObjectHasKey(value, "QMP")) - goto cleanup; - putchar('\n'); - } + else + printLineSkipEmpty("\n", stdout); printLineSkipEmpty(json, stdout); } --=20 2.16.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list