From nobody Thu May 15 13:30:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1508253896363643.0978192326462; Tue, 17 Oct 2017 08:24:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0B882820FC; Tue, 17 Oct 2017 15:24:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBA8164452; Tue, 17 Oct 2017 15:24:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7F8C4180596F; Tue, 17 Oct 2017 15:24:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9HFOgdY007107 for ; Tue, 17 Oct 2017 11:24:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id B868B78002; Tue, 17 Oct 2017 15:24:42 +0000 (UTC) Received: from beluga.usersys.redhat.com (unknown [10.43.2.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18FB078004; Tue, 17 Oct 2017 15:24:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0B882820FC Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Erik Skultety To: libvir-list@redhat.com Date: Tue, 17 Oct 2017 17:24:31 +0200 Message-Id: <62fea6f4a07eb780a02b2ff06bc45c278f859114.1508253701.git.eskultet@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Erik Skultety Subject: [libvirt] [PATCH 2/2] maint: Remove not-so-much informative block commentaries X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 17 Oct 2017 15:24:55 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" There were a bunch of commentary blocks that were literally useless in terms of describing what the code following them does, since most of them were documenting "the obvious" or it just wouldn't help at all. Signed-off-by: Erik Skultety --- daemon/remote.c | 7 ------- src/network/bridge_driver.c | 2 -- src/util/virconf.c | 33 --------------------------------- src/util/virerror.h | 5 ----- src/util/virxml.c | 6 ------ src/vbox/vbox_XPCOMCGlue.c | 9 --------- src/xen/xend_internal.c | 11 ----------- src/xen/xs_internal.c | 10 ---------- src/xenconfig/xen_sxpr.c | 5 ----- 9 files changed, 88 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index fd8542120..3f7d2d344 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -3750,10 +3750,6 @@ remoteDispatchAuthPolkit(virNetServerPtr server, } =20 =20 -/*************************************************************** - * NODE INFO APIS - **************************************************************/ - static int remoteDispatchNodeDeviceGetParent(virNetServerPtr server ATTRIBUTE_UNUSED, virNetServerClientPtr client ATTRIBUTE_U= NUSED, @@ -3864,9 +3860,6 @@ remoteDispatchConnectUnregisterCloseCallback(virNetSe= rverPtr server ATTRIBUTE_UN return rv; } =20 -/*************************** - * Register / deregister events - ***************************/ static int remoteDispatchConnectDomainEventRegister(virNetServerPtr server ATTRIBUTE_= UNUSED, virNetServerClientPtr client, diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 530d00ff3..fcaa66df9 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -4286,8 +4286,6 @@ networkRegister(void) } =20 =20 -/********************************************************/ - /* A unified function to log network connections and disconnections */ =20 static void diff --git a/src/util/virconf.c b/src/util/virconf.c index a88cc9901..5822ee45e 100644 --- a/src/util/virconf.c +++ b/src/util/virconf.c @@ -44,12 +44,6 @@ =20 VIR_LOG_INIT("util.conf"); =20 -/************************************************************************ - * * - * Structures and macros used by the mini parser * - * * - ************************************************************************/ - typedef struct _virConfParserCtxt virConfParserCtxt; typedef virConfParserCtxt *virConfParserCtxtPtr; =20 @@ -75,12 +69,6 @@ struct _virConfParserCtxt { do { while ((ctxt->cur < ctxt->end) && (c_isblank(CUR))) \ ctxt->cur++; } while (0) =20 -/************************************************************************ - * * - * Structures used by configuration data * - * * - ************************************************************************/ - VIR_ENUM_IMPL(virConf, VIR_CONF_LAST, "*unexpected*", "long", @@ -133,12 +121,6 @@ virConfErrorHelper(const char *file, const char *func,= size_t line, } =20 =20 -/************************************************************************ - * * - * Structures allocations and deallocations * - * * - ************************************************************************/ - /** * virConfFreeList: * @list: the list to free @@ -260,11 +242,6 @@ virConfAddEntry(virConfPtr conf, char *name, virConfVa= luePtr value, char *comm) return ret; } =20 -/************************************************************************ - * * - * Serialization * - * * - ************************************************************************/ =20 /** * virConfSaveValue: @@ -353,11 +330,6 @@ virConfSaveEntry(virBufferPtr buf, virConfEntryPtr cur) return 0; } =20 -/************************************************************************ - * * - * The parser core * - * * - ************************************************************************/ =20 /** * virConfParseLong: @@ -754,11 +726,6 @@ virConfParse(const char *filename, const char *content= , int len, return NULL; } =20 -/************************************************************************ - * * - * The module entry points * - * * - ************************************************************************/ =20 /* 10 MB limit on config file size as a sanity check */ #define MAX_CONFIG_FILE_SIZE (1024*1024*10) diff --git a/src/util/virerror.h b/src/util/virerror.h index 054f50fd7..3201d5cec 100644 --- a/src/util/virerror.h +++ b/src/util/virerror.h @@ -27,11 +27,6 @@ extern virErrorFunc virErrorHandler; extern void *virUserData; =20 -/************************************************************************ - * * - * API for error handling * - * * - ************************************************************************/ int virErrorInitialize(void); void virRaiseErrorFull(const char *filename, const char *funcname, diff --git a/src/util/virxml.c b/src/util/virxml.c index a7c28b1e3..1ff1e3653 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -50,12 +50,6 @@ struct virParserData { }; =20 =20 -/************************************************************************ - * * - * Wrappers around libxml2 XPath specific functions * - * * - ************************************************************************/ - /** * virXPathString: * @xpath: the XPath string to evaluate diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c index ff03279ed..cae6d0c62 100644 --- a/src/vbox/vbox_XPCOMCGlue.c +++ b/src/vbox/vbox_XPCOMCGlue.c @@ -26,9 +26,6 @@ * additional information or have any questions. */ =20 -/*************************************************************************= ****** -* Header Files = * -**************************************************************************= *****/ =20 #include =20 @@ -48,9 +45,6 @@ =20 VIR_LOG_INIT("vbox.vbox_XPCOMCGlue"); =20 -/*************************************************************************= ****** -* Defined Constants And Macros = * -**************************************************************************= *****/ #if defined(__linux__) || defined(__linux_gnu__) || defined(__sun__) || \ defined(__FreeBSD__) || defined(__OpenBSD__) || \ defined(__FreeBSD_kernel__) @@ -64,9 +58,6 @@ VIR_LOG_INIT("vbox.vbox_XPCOMCGlue"); #endif =20 =20 -/*************************************************************************= ****** -* Global Variables = * -**************************************************************************= *****/ /** The dlopen handle for VBoxXPCOMC. */ static void *hVBoxXPCOMC; /** Pointer to the VBoxXPCOMC function table. */ diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index ccb1478b3..e4edfd6f8 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -1122,17 +1122,6 @@ sexpr_to_domain(virConnectPtr conn ATTRIBUTE_UNUSED,= const struct sexpr *root) } =20 =20 -/***************************************************************** - ****** - ****** - ****** - ****** - Refactored - ****** - ****** - ****** - ****** - *****************************************************************/ /** * xenDaemonOpen: * @conn: an existing virtual connection block diff --git a/src/xen/xs_internal.c b/src/xen/xs_internal.c index 60d35ebcd..353169da0 100644 --- a/src/xen/xs_internal.c +++ b/src/xen/xs_internal.c @@ -59,11 +59,6 @@ VIR_LOG_INIT("xen.xs_internal"); static void xenStoreWatchEvent(int watch, int fd, int events, void *data); static void xenStoreWatchListFree(xenStoreWatchListPtr list); =20 -/************************************************************************ - * * - * Helper internal APIs * - * * - ************************************************************************/ =20 /** * virDomainDoStoreQuery: @@ -91,11 +86,6 @@ virDomainDoStoreQuery(virConnectPtr conn, int domid, con= st char *path) return xs_read(priv->xshandle, 0, &s[0], &len); } =20 -/************************************************************************ - * * - * Canonical internal APIs * - * * - ************************************************************************/ /** * xenStoreOpen: * @conn: pointer to the connection block diff --git a/src/xenconfig/xen_sxpr.c b/src/xenconfig/xen_sxpr.c index fefa61ac2..358d0cbef 100644 --- a/src/xenconfig/xen_sxpr.c +++ b/src/xenconfig/xen_sxpr.c @@ -70,11 +70,6 @@ int xenGetDomIdFromSxpr(const struct sexpr *root, int *i= d) return 0; } =20 -/***************************************************************** - ****** - ****** Parsing of S-Expression into virDomainDef objects - ****** - *****************************************************************/ =20 /** * xenParseSxprOS: --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list