From nobody Tue May 13 19:44:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1530649218728120.81009412539368; Tue, 3 Jul 2018 13:20:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73B5230001E7; Tue, 3 Jul 2018 20:20:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DEA09171EF; Tue, 3 Jul 2018 20:20:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0884918037ED; Tue, 3 Jul 2018 20:20:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w63KKBwF005166 for ; Tue, 3 Jul 2018 16:20:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id AD1BB2027057; Tue, 3 Jul 2018 20:20:11 +0000 (UTC) Received: from dhcp-17-130.bos.redhat.com (dhcp-17-130.bos.redhat.com [10.18.17.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 951142026D76; Tue, 3 Jul 2018 20:20:11 +0000 (UTC) From: Anya Harter To: libvir-list@redhat.com Date: Tue, 3 Jul 2018 16:19:49 -0400 Message-Id: <6ab96746c1cd6422d48f0bf13a4480f46a27d3bf.1530648863.git.aharter@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Anya Harter Subject: [libvirt] [PATCH 2/4] domain_addr: make virDomainCCWAddress funcs static X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 03 Jul 2018 20:20:17 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Allocate, Validate, SetCreate last uses of these functions outside domain_addr.c removed in commit: 7bdd06b4e103269992122603949f585fc2bfdc6 Signed-off-by: Anya Harter --- src/conf/domain_addr.c | 6 +++--- src/conf/domain_addr.h | 12 ------------ src/libvirt_private.syms | 3 --- 3 files changed, 3 insertions(+), 18 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index ec2dfdbbdc..1922412853 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -1134,7 +1134,7 @@ virDomainCCWAddressAssign(virDomainDeviceInfoPtr dev, return ret; } =20 -int +static int ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4) virDomainCCWAddressAllocate(virDomainDefPtr def ATTRIBUTE_UNUSED, virDomainDeviceDefPtr dev ATTRIBUTE_UNUSED, virDomainDeviceInfoPtr info, @@ -1143,7 +1143,7 @@ virDomainCCWAddressAllocate(virDomainDefPtr def ATTRI= BUTE_UNUSED, return virDomainCCWAddressAssign(info, data, true); } =20 -int +static int ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4) virDomainCCWAddressValidate(virDomainDefPtr def ATTRIBUTE_UNUSED, virDomainDeviceDefPtr dev ATTRIBUTE_UNUSED, virDomainDeviceInfoPtr info, @@ -1161,7 +1161,7 @@ void virDomainCCWAddressSetFree(virDomainCCWAddressSe= tPtr addrs) VIR_FREE(addrs); } =20 -virDomainCCWAddressSetPtr +static virDomainCCWAddressSetPtr virDomainCCWAddressSetCreate(void) { virDomainCCWAddressSetPtr addrs =3D NULL; diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h index fc87c14eba..fc5ddcf6f1 100644 --- a/src/conf/domain_addr.h +++ b/src/conf/domain_addr.h @@ -186,18 +186,6 @@ int virDomainCCWAddressAssign(virDomainDeviceInfoPtr d= ev, bool autoassign) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); void virDomainCCWAddressSetFree(virDomainCCWAddressSetPtr addrs); -int virDomainCCWAddressAllocate(virDomainDefPtr def, - virDomainDeviceDefPtr dev, - virDomainDeviceInfoPtr info, - void *data) - ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); -int virDomainCCWAddressValidate(virDomainDefPtr def, - virDomainDeviceDefPtr dev, - virDomainDeviceInfoPtr info, - void *data) - ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); - -virDomainCCWAddressSetPtr virDomainCCWAddressSetCreate(void); =20 virDomainCCWAddressSetPtr virDomainCCWAddressSetCreateFromDomain(virDomainDefPtr def) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7000620b41..fef38d29fa 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -104,12 +104,9 @@ virPCIDeviceAddressParseXML; =20 =20 # conf/domain_addr.h -virDomainCCWAddressAllocate; virDomainCCWAddressAssign; -virDomainCCWAddressSetCreate; virDomainCCWAddressSetCreateFromDomain; virDomainCCWAddressSetFree; -virDomainCCWAddressValidate; virDomainPCIAddressAsString; virDomainPCIAddressBusIsFullyReserved; virDomainPCIAddressBusSetModel; --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list