From nobody Thu May 15 21:30:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1506006333530615.3757248928558; Thu, 21 Sep 2017 08:05:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 440DAC0587C1; Thu, 21 Sep 2017 15:05:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1AD085EE16; Thu, 21 Sep 2017 15:05:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D83053FACF; Thu, 21 Sep 2017 15:05:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v8LElenD014710 for ; Thu, 21 Sep 2017 10:47:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 138A360178; Thu, 21 Sep 2017 14:47:40 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90022600C2 for ; Thu, 21 Sep 2017 14:47:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 440DAC0587C1 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 21 Sep 2017 16:47:09 +0200 Message-Id: <7025f23d4de18f3935100bed76891693faf5b776.1506005021.git.mprivozn@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v1 5/7] domain: Add virDomainDefAssignAliasesCallback X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 21 Sep 2017 15:05:31 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This will be called at the end of virDomainDefPostParse to allow hypervisor drivers to fill in device aliases. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 7 +++++++ src/conf/domain_conf.h | 13 +++++++++++++ 2 files changed, 20 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e3e9fc748..653357531 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5011,6 +5011,13 @@ virDomainDefPostParseInternal(virDomainDefPtr def, goto cleanup; } =20 + if (xmlopt->config.assignAliasesCallback) { + ret =3D xmlopt->config.assignAliasesCallback(def, caps, parseFlags, + xmlopt->config.priv, + data.parseOpaque); + if (virDomainDefPostParseCheckFailure(def, parseFlags, ret) < 0) + goto cleanup; + } if ((ret =3D virDomainDefPostParseCheckFeatures(def, xmlopt)) < 0) goto cleanup; =20 diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index e11ae5247..764360ccb 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2559,6 +2559,18 @@ typedef int (*virDomainDefAssignAddressesCallback)(v= irDomainDef *def, void *opaque, void *parseOpaque); =20 +/* Driver callback for assigning device aliases, called at the + * end of parsing, after all defaults and implicit devices have + * been added and all addresses were assigned. @parseOpaque is + * opaque data passed by virDomainDefParse *caller, @opaque is + * opaque data set by driver (usually pointer to driver private + * data). */ +typedef int (*virDomainDefAssignAliasesCallback)(virDomainDefPtr def, + virCapsPtr caps, + unsigned int parseFlags, + void *opaque, + void *parseOpaque); + typedef int (*virDomainDefPostParseDataAlloc)(const virDomainDef *def, virCapsPtr caps, unsigned int parseFlags, @@ -2588,6 +2600,7 @@ struct _virDomainDefParserConfig { virDomainDefPostParseCallback domainPostParseCallback; virDomainDeviceDefPostParseCallback devicesPostParseCallback; virDomainDefAssignAddressesCallback assignAddressesCallback; + virDomainDefAssignAliasesCallback assignAliasesCallback; virDomainDefPostParseDataFree domainPostParseDataFree; =20 /* validation callbacks */ --=20 2.13.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list