connect: fix deregistering of NodeDevice events

[libvirt] [dbus PATCH] connect: fix deregistering of NodeDevice events

Posted by Anya Harter 5 years, 10 months ago

Signed-off-by: Anya Harter <aharter@redhat.com>
---
 src/connect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/connect.c b/src/connect.c
index 09e5628..32dda14 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -68,7 +68,7 @@ virtDBusConnectClose(virtDBusConnect *connect,
     for (gint i = 0; i < VIR_NODE_DEVICE_EVENT_ID_LAST; i++) {
         if (connect->nodeDevCallbackIds[i] >= 0) {
             if (deregisterEvents) {
-                virConnectNetworkEventDeregisterAny(connect->connection,
+                virConnectNodeDeviceEventDeregisterAny(connect->connection,
                                                     connect->nodeDevCallbackIds[i]);
             }
             connect->nodeDevCallbackIds[i] = -1;
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH] connect: fix deregistering of NodeDevice events

Posted by Katerina Koukiou 5 years, 10 months ago

On Mon, Jun 25, 2018 at 09:30:49AM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter <aharter@redhat.com>
> ---
>  src/connect.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/connect.c b/src/connect.c
> index 09e5628..32dda14 100644
> --- a/src/connect.c
> +++ b/src/connect.c
> @@ -68,7 +68,7 @@ virtDBusConnectClose(virtDBusConnect *connect,
>      for (gint i = 0; i < VIR_NODE_DEVICE_EVENT_ID_LAST; i++) {
>          if (connect->nodeDevCallbackIds[i] >= 0) {
>              if (deregisterEvents) {
> -                virConnectNetworkEventDeregisterAny(connect->connection,
> +                virConnectNodeDeviceEventDeregisterAny(connect->connection,
>                                                      connect->nodeDevCallbackIds[i]);

Indentation is off here. Otherwise looks good.
With this adjusted.

Reviewed-by: Katerina Koukiou <kkoukiou@redhat.com>
>              }
>              connect->nodeDevCallbackIds[i] = -1;
> -- 
> 2.17.1
> 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list