From nobody Wed May 14 07:04:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1525687859465397.86833150346627; Mon, 7 May 2018 03:10:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5C44C047B66; Mon, 7 May 2018 10:10:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 935B365960; Mon, 7 May 2018 10:10:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1F68F180BADC; Mon, 7 May 2018 10:10:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w47A6hHM022974 for ; Mon, 7 May 2018 06:06:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 89D06111F3DC; Mon, 7 May 2018 10:06:43 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E6EA111F3DA for ; Mon, 7 May 2018 10:06:43 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 7 May 2018 12:06:33 +0200 Message-Id: <7301ecface0267ef13b255784d3444790a7e0f57.1525687535.git.phrdina@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 6/9] domain: Return error if libvirt API fails X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 07 May 2018 10:10:58 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- src/domain.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/domain.c b/src/domain.c index 20d41fe..b361aa6 100644 --- a/src/domain.c +++ b/src/domain.c @@ -1339,7 +1339,10 @@ virtDBusDomainGetMemoryParameters(GVariant *inArgs, return; =20 ret =3D virDomainGetMemoryParameters(domain, NULL, ¶ms.nparams, fl= ags); - if (ret =3D=3D 0 && params.nparams !=3D 0) { + if (ret < 0) + return virtDBusUtilSetLastVirtError(error); + + if (params.nparams !=3D 0) { params.params =3D g_new0(virTypedParameter, params.nparams); if (virDomainGetMemoryParameters(domain, params.params, ¶ms.nparams, flags) < 0) { @@ -1475,7 +1478,10 @@ virtDBusDomainGetSchedulerParameters(GVariant *inArg= s, return; =20 ret =3D virDomainGetSchedulerType(domain, ¶ms.nparams); - if (ret && params.nparams !=3D 0) { + if (!ret) + return virtDBusUtilSetLastVirtError(error); + + if (params.nparams !=3D 0) { params.params =3D g_new0(virTypedParameter, params.nparams); if (virDomainGetSchedulerParametersFlags(domain, params.params, ¶ms.nparams, 0)) --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list