From nobody Wed May 14 13:56:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1524487540813173.38328915982788; Mon, 23 Apr 2018 05:45:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A2AD80471; Mon, 23 Apr 2018 12:45:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 135A16FEC7; Mon, 23 Apr 2018 12:45:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BC21F4CAB6; Mon, 23 Apr 2018 12:45:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3NCjB6E011890 for ; Mon, 23 Apr 2018 08:45:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3698310FFE6F; Mon, 23 Apr 2018 12:45:11 +0000 (UTC) Received: from caroline.localdomain (unknown [10.43.2.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC0F710FFE74 for ; Mon, 23 Apr 2018 12:45:09 +0000 (UTC) Received: from caroline.brq.redhat.com (caroline.usersys.redhat.com [127.0.0.1]) by caroline.localdomain (Postfix) with ESMTP id A159E12006F for ; Mon, 23 Apr 2018 14:45:07 +0200 (CEST) From: Martin Kletzander To: libvir-list@redhat.com Date: Mon, 23 Apr 2018 14:44:33 +0200 Message-Id: <73c5c6b6d9d7106d0c3997b057e4eee106bceb12.1524487472.git.mkletzan@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 05/29] hyperv: Add spaces after casts X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 23 Apr 2018 12:45:39 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Martin Kletzander --- src/hyperv/hyperv_driver.c | 60 +++++++++++++++++++------------------- src/hyperv/hyperv_wmi.c | 12 ++++---- 2 files changed, 36 insertions(+), 36 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index d02c0ac3734e..e3ea0a0eb559 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -244,7 +244,7 @@ hypervConnectGetHostname(virConnectPtr conn) ignore_value(VIR_STRDUP(hostname, computerSystem->data.common->DNSHost= Name)); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return hostname; } @@ -339,8 +339,8 @@ hypervNodeGetInfo(virConnectPtr conn, virNodeInfoPtr in= fo) result =3D 0; =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); - hypervFreeObject(priv, (hypervObject *)processorList); + hypervFreeObject(priv, (hypervObject *) computerSystem); + hypervFreeObject(priv, (hypervObject *) processorList); =20 return result; } @@ -382,7 +382,7 @@ hypervConnectListDomains(virConnectPtr conn, int *ids, = int maxids) success =3D true; =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystemList); + hypervFreeObject(priv, (hypervObject *) computerSystemList); =20 return success ? count : -1; } @@ -418,7 +418,7 @@ hypervConnectNumOfDomains(virConnectPtr conn) success =3D true; =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystemList); + hypervFreeObject(priv, (hypervObject *) computerSystemList); =20 return success ? count : -1; } @@ -449,7 +449,7 @@ hypervDomainLookupByID(virConnectPtr conn, int id) hypervMsvmComputerSystemToDomain(conn, computerSystem, &domain); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return domain; } @@ -484,7 +484,7 @@ hypervDomainLookupByUUID(virConnectPtr conn, const unsi= gned char *uuid) hypervMsvmComputerSystemToDomain(conn, computerSystem, &domain); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return domain; } @@ -516,7 +516,7 @@ hypervDomainLookupByName(virConnectPtr conn, const char= *name) hypervMsvmComputerSystemToDomain(conn, computerSystem, &domain); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return domain; } @@ -544,7 +544,7 @@ hypervDomainSuspend(virDomainPtr domain) (domain, MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_PAUSED); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return result; } @@ -572,7 +572,7 @@ hypervDomainResume(virDomainPtr domain) (domain, MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return result; } @@ -603,7 +603,7 @@ hypervDomainDestroyFlags(virDomainPtr domain, unsigned = int flags) (domain, MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_DISABLED); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return result; } @@ -724,10 +724,10 @@ hypervDomainGetInfo(virDomainPtr domain, virDomainInf= oPtr info) result =3D 0; =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); - hypervFreeObject(priv, (hypervObject *)virtualSystemSettingData); - hypervFreeObject(priv, (hypervObject *)processorSettingData); - hypervFreeObject(priv, (hypervObject *)memorySettingData); + hypervFreeObject(priv, (hypervObject *) computerSystem); + hypervFreeObject(priv, (hypervObject *) virtualSystemSettingData); + hypervFreeObject(priv, (hypervObject *) processorSettingData); + hypervFreeObject(priv, (hypervObject *) memorySettingData); =20 return result; } @@ -755,7 +755,7 @@ hypervDomainGetState(virDomainPtr domain, int *state, i= nt *reason, result =3D 0; =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return result; } @@ -876,7 +876,7 @@ hypervDomainGetXMLDesc(virDomainPtr domain, unsigned in= t flags) goto cleanup; } else if (priv->wmiVersion =3D=3D HYPERV_WMI_VERSION_V2 && virtualSystemSettingData->data.v2->Notes.data !=3D NULL) { - char **notes =3D (char **)virtualSystemSettingData->data.v2->Notes= .data; + char **notes =3D (char **) virtualSystemSettingData->data.v2->Note= s.data; virBuffer buf =3D VIR_BUFFER_INITIALIZER; size_t i =3D 0; =20 @@ -919,10 +919,10 @@ hypervDomainGetXMLDesc(virDomainPtr domain, unsigned = int flags) =20 cleanup: virDomainDefFree(def); - hypervFreeObject(priv, (hypervObject *)computerSystem); - hypervFreeObject(priv, (hypervObject *)virtualSystemSettingData); - hypervFreeObject(priv, (hypervObject *)processorSettingData); - hypervFreeObject(priv, (hypervObject *)memorySettingData); + hypervFreeObject(priv, (hypervObject *) computerSystem); + hypervFreeObject(priv, (hypervObject *) virtualSystemSettingData); + hypervFreeObject(priv, (hypervObject *) processorSettingData); + hypervFreeObject(priv, (hypervObject *) memorySettingData); =20 return xml; } @@ -975,7 +975,7 @@ hypervConnectListDefinedDomains(virConnectPtr conn, cha= r **const names, int maxn count =3D -1; } =20 - hypervFreeObject(priv, (hypervObject *)computerSystemList); + hypervFreeObject(priv, (hypervObject *) computerSystemList); =20 return count; } @@ -1011,7 +1011,7 @@ hypervConnectNumOfDefinedDomains(virConnectPtr conn) success =3D true; =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystemList); + hypervFreeObject(priv, (hypervObject *) computerSystemList); =20 return success ? count : -1; } @@ -1040,7 +1040,7 @@ hypervDomainCreateWithFlags(virDomainPtr domain, unsi= gned int flags) (domain, MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return result; } @@ -1113,7 +1113,7 @@ hypervDomainIsActive(virDomainPtr domain) result =3D hypervIsMsvmComputerSystemActive(computerSystem, NULL) ? 1 = : 0; =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return result; } @@ -1161,7 +1161,7 @@ hypervDomainManagedSave(virDomainPtr domain, unsigned= int flags) (domain, MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_SUSPENDED); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return result; } @@ -1184,7 +1184,7 @@ hypervDomainHasManagedSaveImage(virDomainPtr domain, = unsigned int flags) MSVM_COMPUTERSYSTEM_ENABLEDSTATE_SUSPENDED ? 1 : 0; =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return result; } @@ -1214,7 +1214,7 @@ hypervDomainManagedSaveRemove(virDomainPtr domain, un= signed int flags) (domain, MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_DISABLED); =20 cleanup: - hypervFreeObject(priv, (hypervObject *)computerSystem); + hypervFreeObject(priv, (hypervObject *) computerSystem); =20 return result; } @@ -1344,7 +1344,7 @@ hypervConnectListAllDomains(virConnectPtr conn, VIR_FREE(doms); } =20 - hypervFreeObject(priv, (hypervObject *)computerSystemList); + hypervFreeObject(priv, (hypervObject *) computerSystemList); =20 return ret; } @@ -1367,7 +1367,7 @@ hypervDomainSendKey(virDomainPtr domain, unsigned int= codeset, Msvm_Keyboard *keyboard =3D NULL; virBuffer query =3D VIR_BUFFER_INITIALIZER; hypervInvokeParamsListPtr params =3D NULL; - char keycodeStr[INT_BUFSIZE_BOUND(int)]; + char keycodeStr[INT_BUFSIZE_BOUND(int) ]; =20 virCheckFlags(0, -1); =20 diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 5e2b3d7edf5b..37389d0661c0 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -733,7 +733,7 @@ hypervSerializeEmbeddedParam(hypervParamPtr p, const ch= ar *resourceUri, ws_xml_dump_memory_node_tree(xmlNodeInstance, &cdataContent, &len); =20 if (!(xmlNodeCdata =3D xmlNewCDataBlock((xmlDocPtr) xmlDocCdata, - (xmlChar *)cdataContent, len))) { + (xmlChar *) cdataContent, len))) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could not create CDATA element")); goto cleanup; @@ -745,7 +745,7 @@ hypervSerializeEmbeddedParam(hypervParamPtr p, const ch= ar *resourceUri, * FIXME: there is no openwsman wrapper for xmlNewCDataBlock, so inste= ad * silence clang alignment warnings by casting to a void pointer first */ - if (!(xmlAddChild((xmlNodePtr)(void *)xmlNodeParam, xmlNodeCdata))) { + if (!(xmlAddChild((xmlNodePtr)(void *) xmlNodeParam, xmlNodeCdata))) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could not add CDATA to doc root")); goto cleanup; @@ -1368,7 +1368,7 @@ hypervInvokeMsvmComputerSystemRequestStateChange(virD= omainPtr domain, goto cleanup; =20 /* Check return value */ - returnValue =3D ws_xml_get_xpath_value(response, (char *)"/s:Envelope/= s:Body/p:RequestStateChange_OUTPUT/p:ReturnValue"); + returnValue =3D ws_xml_get_xpath_value(response, (char *) "/s:Envelope= /s:Body/p:RequestStateChange_OUTPUT/p:ReturnValue"); =20 if (returnValue =3D=3D NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, @@ -1385,7 +1385,7 @@ hypervInvokeMsvmComputerSystemRequestStateChange(virD= omainPtr domain, =20 if (returnCode =3D=3D CIM_RETURNCODE_TRANSITION_STARTED) { /* Get concrete job object */ - instanceID =3D ws_xml_get_xpath_value(response, (char *)"/s:Envelo= pe/s:Body/p:RequestStateChange_OUTPUT/p:Job/a:ReferenceParameters/w:Selecto= rSet/w:Selector[@Name=3D'InstanceID']"); + instanceID =3D ws_xml_get_xpath_value(response, (char *) "/s:Envel= ope/s:Body/p:RequestStateChange_OUTPUT/p:Job/a:ReferenceParameters/w:Select= orSet/w:Selector[@Name=3D'InstanceID']"); =20 if (instanceID =3D=3D NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, @@ -1415,7 +1415,7 @@ hypervInvokeMsvmComputerSystemRequestStateChange(virD= omainPtr domain, case MSVM_CONCRETEJOB_JOBSTATE_STARTING: case MSVM_CONCRETEJOB_JOBSTATE_RUNNING: case MSVM_CONCRETEJOB_JOBSTATE_SHUTTING_DOWN: - hypervFreeObject(priv, (hypervObject *)concreteJob); + hypervFreeObject(priv, (hypervObject *) concreteJob); concreteJob =3D NULL; =20 usleep(100 * 1000); @@ -1460,7 +1460,7 @@ hypervInvokeMsvmComputerSystemRequestStateChange(virD= omainPtr domain, VIR_FREE(properties); VIR_FREE(returnValue); VIR_FREE(instanceID); - hypervFreeObject(priv, (hypervObject *)concreteJob); + hypervFreeObject(priv, (hypervObject *) concreteJob); =20 return result; } --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list