From nobody Wed May 14 00:21:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1528780610138325.871065540008; Mon, 11 Jun 2018 22:16:50 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 61E8C356F6; Tue, 12 Jun 2018 05:16:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E80525C543; Tue, 12 Jun 2018 05:16:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2B7A31804480; Tue, 12 Jun 2018 05:16:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w5C5Ggam006500 for ; Tue, 12 Jun 2018 01:16:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id CD0D7202660C; Tue, 12 Jun 2018 05:16:42 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 703BB2026609 for ; Tue, 12 Jun 2018 05:16:42 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Tue, 12 Jun 2018 07:16:38 +0200 Message-Id: <7d51ebf1924b4e3af51421b5026a1751814d3ac9.1528780553.git.phrdina@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [python PATCH 1/4] libvirt-utils: remove unused py_str function X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 12 Jun 2018 05:16:49 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Commit <57a160b5248ba47d4e1c9d22d95847dad8e0524f> removed last usage but did not remove the function itself. Signed-off-by: Pavel Hrdina Reviewed-by: J=EF=BF=BDn Tomko --- libvirt-utils.c | 14 -------------- libvirt-utils.h | 1 - 2 files changed, 15 deletions(-) diff --git a/libvirt-utils.c b/libvirt-utils.c index f7b4478..e17e794 100644 --- a/libvirt-utils.c +++ b/libvirt-utils.c @@ -199,20 +199,6 @@ virTypedParamsFree(virTypedParameterPtr params, } #endif /* ! LIBVIR_CHECK_VERSION(1, 0, 2) */ =20 -char * -py_str(PyObject *obj) -{ - PyObject *str =3D PyObject_Str(obj); - char *ret; - if (!str) { - PyErr_Print(); - PyErr_Clear(); - return NULL; - }; - libvirt_charPtrUnwrap(str, &ret); - return ret; -} - /* Helper function to convert a virTypedParameter output array into a * Python dictionary for return to the user. Return NULL on failure, * after raising a python exception. */ diff --git a/libvirt-utils.h b/libvirt-utils.h index 0af1e62..cc3d278 100644 --- a/libvirt-utils.h +++ b/libvirt-utils.h @@ -319,7 +319,6 @@ void virTypedParamsClear(virTypedParameterPtr params, i= nt nparams); void virTypedParamsFree(virTypedParameterPtr params, int nparams); # endif /* ! LIBVIR_CHECK_VERSION(1, 0, 2) */ =20 -char * py_str(PyObject *obj); PyObject * getPyVirTypedParameter(const virTypedParameter *params, int nparams); virTypedParameterPtr setPyVirTypedParameter(PyObject *info, --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list