From nobody Fri Apr 19 07:10:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1534414972843112.16678465212385; Thu, 16 Aug 2018 03:22:52 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E757880F7C; Thu, 16 Aug 2018 10:22:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADB3F183C0; Thu, 16 Aug 2018 10:22:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 41DCB18037F1; Thu, 16 Aug 2018 10:22:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w7GAMSeF008427 for ; Thu, 16 Aug 2018 06:22:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id 62BE72027047; Thu, 16 Aug 2018 10:22:28 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0150A2026D7E for ; Thu, 16 Aug 2018 10:22:26 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 16 Aug 2018 12:22:24 +0200 Message-Id: <7e6903171033293d4188f871a3935600bfc9e845.1534414944.git.mprivozn@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemu_command: Fix memleak in qemuBuildFloppyCommandLineControllerOptions X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 16 Aug 2018 10:22:51 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Even though the buffer is passed to virCommand we still need to free it. =3D=3D191201=3D=3D 1,010 bytes in 1 blocks are definitely lost in loss reco= rd 826 of 836 =3D=3D191201=3D=3D at 0x4C2CE3F: malloc (vg_replace_malloc.c:298) =3D=3D191201=3D=3D by 0x4C2F1BF: realloc (vg_replace_malloc.c:785) =3D=3D191201=3D=3D by 0x5D39E82: virReallocN (viralloc.c:245) =3D=3D191201=3D=3D by 0x5D3E8F2: virBufferGrow (virbuffer.c:150) =3D=3D191201=3D=3D by 0x5D3E9C8: virBufferAdd (virbuffer.c:185) =3D=3D191201=3D=3D by 0x56EAC98: qemuBuildFloppyCommandLineControllerOpt= ions (qemu_command.c:2162) =3D=3D191201=3D=3D by 0x56EB3E1: qemuBuildDisksCommandLine (qemu_command= .c:2370) =3D=3D191201=3D=3D by 0x570055E: qemuBuildCommandLine (qemu_command.c:10= 315) =3D=3D191201=3D=3D by 0x575EA7F: qemuProcessCreatePretendCmd (qemu_proce= ss.c:6777) =3D=3D191201=3D=3D by 0x113DAB: testCompareXMLToArgv (qemuxml2argvtest.c= :598) =3D=3D191201=3D=3D by 0x13A75B: virTestRun (testutils.c:180) =3D=3D191201=3D=3D by 0x138BE8: mymain (qemuxml2argvtest.c:2975) Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/qemu/qemu_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ddb90895e0..96fc360f4a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2225,6 +2225,7 @@ qemuBuildFloppyCommandLineControllerOptions(virComman= dPtr cmd, VIR_FREE(backendAlias); VIR_FREE(backendStr); VIR_FREE(bootindexStr); + virBufferFreeAndReset(&fdc_opts); return ret; } =20 --=20 2.16.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list