src: Clean *.logrotate, .aug and libvirtd.policy files on 'make clean'

[libvirt] [PATCH] src: Clean *.logrotate, .aug and libvirtd.policy files on 'make clean'

Posted by Michal Privoznik 7 years, 2 months ago

Before 3f055b5997c we were doing that. However after the commit
we are leaving the files behind.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

Pushed under build breaker rule.

 src/Makefile.am | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 41a3cb262..2166e17db 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1376,7 +1376,7 @@ augeastest_DATA += test_libvirtd.aug
 
 conf_DATA += remote/libvirtd.conf
 
-CLEANFILES += tets_libvirtd.aug
+CLEANFILES += test_libvirtd.aug
 
 if WITH_POLKIT
 if WITH_POLKIT0
@@ -1389,6 +1389,7 @@ endif ! WITH_POLKIT0
 endif WITH_POLKIT
 
 BUILT_SOURCES += libvirtd.policy
+CLEANFILES += libvirtd.policy
 
 libvirtd.policy: remote/libvirtd.policy.in $(top_builddir)/config.status
 	$(AM_V_GEN) sed \
@@ -2868,6 +2869,7 @@ if WITH_LIBVIRTD
 LOGROTATE_FILES := $(LOGROTATE_FILES_IN:remote/%.in=%)
 
 BUILT_SOURCES += $(LOGROTATE_FILES)
+CLEANFILES += $(LOGROTATE_FILES)
 
 %.logrotate: remote/%.logrotate.in
 	$(AM_V_GEN)sed \
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] src: Clean *.logrotate, .aug and libvirtd.policy files on 'make clean'

Posted by Daniel P. Berrangé 7 years, 2 months ago

On Thu, Feb 22, 2018 at 02:34:56PM +0100, Michal Privoznik wrote:
> Before 3f055b5997c we were doing that. However after the commit
> we are leaving the files behind.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> 
> Pushed under build breaker rule.

What are you running that detects this bug during build ?


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] src: Clean *.logrotate, .aug and libvirtd.policy files on 'make clean'

Posted by Michal Privoznik 7 years, 2 months ago

On 02/22/2018 02:37 PM, Daniel P. Berrangé wrote:
> On Thu, Feb 22, 2018 at 02:34:56PM +0100, Michal Privoznik wrote:
>> Before 3f055b5997c we were doing that. However after the commit
>> we are leaving the files behind.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>> ---
>>
>> Pushed under build breaker rule.
> 
> What are you running that detects this bug during build ?

make distcheck

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] src: Clean *.logrotate, .aug and libvirtd.policy files on 'make clean'

Posted by Daniel P. Berrangé 7 years, 2 months ago

On Thu, Feb 22, 2018 at 02:44:58PM +0100, Michal Privoznik wrote:
> On 02/22/2018 02:37 PM, Daniel P. Berrangé wrote:
> > On Thu, Feb 22, 2018 at 02:34:56PM +0100, Michal Privoznik wrote:
> >> Before 3f055b5997c we were doing that. However after the commit
> >> we are leaving the files behind.
> >>
> >> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> >> ---
> >>
> >> Pushed under build breaker rule.
> > 
> > What are you running that detects this bug during build ?
> 
> make distcheck

Ah yes, of course.  I'll look to get distcheck included in Travis too.

It would be nice to include the Jenkins CI, but I fear it would increase
the job times significantly  and we've already overloaded there

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list