From nobody Thu Apr 25 21:22:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1539865666651606.7751991176102; Thu, 18 Oct 2018 05:27:46 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 432633003185; Thu, 18 Oct 2018 12:27:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E842C6152A; Thu, 18 Oct 2018 12:27:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7C7EE180B5B7; Thu, 18 Oct 2018 12:27:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w9ICRFME026082 for ; Thu, 18 Oct 2018 08:27:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id E588860922; Thu, 18 Oct 2018 12:27:15 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B1E1611BC for ; Thu, 18 Oct 2018 12:27:15 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 18 Oct 2018 14:26:49 +0200 Message-Id: <9c7b466ae7b3377c3037745653ad4525f6fdcb76.1539865556.git.mprivozn@redhat.com> In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [snmp PATCH 11/20] libvirtRegisterEvents: Drop pthread_attr_init X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 18 Oct 2018 12:27:45 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The threads are JOINABLE by default. No need to go through pthread_attr_* circus to set what is default anyway. Signed-off-by: Michal Privoznik --- src/libvirtSnmp.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/libvirtSnmp.c b/src/libvirtSnmp.c index 3b5c17f..88f2ec6 100644 --- a/src/libvirtSnmp.c +++ b/src/libvirtSnmp.c @@ -205,7 +205,7 @@ pollingThreadFunc(void *foo) int libvirtRegisterEvents(virConnectPtr conn) { struct sigaction action_stop; - pthread_attr_t thread_attr; + int ret =3D -1; =20 memset(&action_stop, 0, sizeof action_stop); =20 @@ -226,15 +226,12 @@ libvirtRegisterEvents(virConnectPtr conn) { return -1; =20 /* we need a thread to poll for events */ - pthread_attr_init(&thread_attr); - pthread_attr_setdetachstate(&thread_attr, PTHREAD_CREATE_JOINABLE); + if (pthread_create(&poll_thread, NULL, pollingThreadFunc, NULL)) + goto cleanup; =20 - if (pthread_create(&poll_thread, &thread_attr, pollingThreadFunc, NULL= )) - return -1; - - pthread_attr_destroy(&thread_attr); - - return 0; + ret =3D 0; + cleanup: + return ret; } =20 /* Unregister domain events collection */ --=20 2.18.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list