From nobody Thu May 15 06:56:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1512638654190743.2691518655414; Thu, 7 Dec 2017 01:24:14 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8A9DD13A4E; Thu, 7 Dec 2017 09:24:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BD9D183A6; Thu, 7 Dec 2017 09:24:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C6BD74BB79; Thu, 7 Dec 2017 09:24:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vB79NB5s007284 for ; Thu, 7 Dec 2017 04:23:11 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5B6F169412; Thu, 7 Dec 2017 09:23:11 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 876986940E; Thu, 7 Dec 2017 09:23:10 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 7 Dec 2017 10:22:58 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: drewwynne@gmail.com, dzamirski@datto.com Subject: [libvirt] [libvirt-php][PATCH 3/7] installation_get_xml: Don't override defaults of and friends X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 07 Dec 2017 09:24:13 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We don't really need to override the defaults because libvirt chooses sane ones. Signed-off-by: Michal Privoznik --- src/libvirt-php.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 51534a5..307412e 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -2345,9 +2345,6 @@ char *installation_get_xml(virConnectPtr conn, char *= name, int memMB, " %s\n" " \n" " \n" - " destroy\n" - " destroy\n" - " destroy\n" " %d\n" " \n" " %s\n" @@ -2388,9 +2385,6 @@ char *installation_get_xml(virConnectPtr conn, char *= name, int memMB, " %s\n" " \n" " \n" - " destroy\n" - " destroy\n" - " destroy\n" " %d\n" " \n" " %s\n" --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list