From nobody Fri May 9 08:22:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1539865878073677.5476711472369; Thu, 18 Oct 2018 05:31:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 42951CD17A; Thu, 18 Oct 2018 12:31:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB97E611C9; Thu, 18 Oct 2018 12:31:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 62EE218005B3; Thu, 18 Oct 2018 12:31:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w9ICRO39026362 for ; Thu, 18 Oct 2018 08:27:24 -0400 Received: by smtp.corp.redhat.com (Postfix) id 982F3611BC; Thu, 18 Oct 2018 12:27:24 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 19E4260D58 for ; Thu, 18 Oct 2018 12:27:21 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 18 Oct 2018 14:26:56 +0200 Message-Id: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [snmp PATCH 18/20] libvirtSnmp: Report libvirt errors if no domain is found X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 18 Oct 2018 12:31:16 +0000 (UTC) X-ZohoMail: RDMRC_0 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Instead of plain printf(), report proper libvirt error. Signed-off-by: Michal Privoznik --- src/libvirtSnmp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libvirtSnmp.c b/src/libvirtSnmp.c index 2f2f406..c334967 100644 --- a/src/libvirtSnmp.c +++ b/src/libvirtSnmp.c @@ -322,7 +322,7 @@ libvirtSnmpCreate(unsigned char *uuid, int state) } =20 if (!(dom =3D virDomainLookupByUUID(conn, uuid))) { - printf("Cannot find domain to create\n"); + printLibvirtError("No such domain"); return -1; } =20 @@ -344,7 +344,7 @@ libvirtSnmpDestroy(unsigned char *uuid) int ret =3D -1; =20 if (!(dom =3D virDomainLookupByUUID(conn, uuid))) { - printf("Cannot find domain to destroy\n"); + printLibvirtError("No such domain"); return -1; } =20 @@ -366,7 +366,7 @@ libvirtSnmpChangeState(unsigned char *uuid, int newstat= e, int oldstate) int ret =3D -1; =20 if (!(dom =3D virDomainLookupByUUID(conn, uuid))) { - printf("Cannot find domain to change\n"); + printLibvirtError("No such domain"); return 1; } =20 --=20 2.18.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list