From nobody Tue Feb 10 09:35:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1527841224479539.6057142885464; Fri, 1 Jun 2018 01:20:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD92030C1E14; Fri, 1 Jun 2018 08:20:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 838B71001902; Fri, 1 Jun 2018 08:20:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2F2074CA82; Fri, 1 Jun 2018 08:20:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w518KFju028624 for ; Fri, 1 Jun 2018 04:20:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id EC3E72166BB6; Fri, 1 Jun 2018 08:20:14 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90B5F2166BB2 for ; Fri, 1 Jun 2018 08:20:14 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Fri, 1 Jun 2018 10:19:53 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [RFC PATCH 1/9] qemu: monitor: Add possibility to reset command sequence in tests X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 01 Jun 2018 08:20:23 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" qemucapabilitiestest for simplicity uses one test monitor object for simulating work of two separate inquiries of the qemu process. To allow better testing in the future it will be required to reset the counter so that it accurately simulates how qemu would behave. This patch adds a private monitor API which allows to reset the counter which will be usable only in tests. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 11 +++++++++++ src/qemu/qemu_monitor_priv.h | 31 +++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 src/qemu/qemu_monitor_priv.h diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 43f1d2f816..2405c77f17 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -48,6 +48,9 @@ # include "libvirt_qemu_probes.h" #endif +#define __QEMU_MONITOR_PRIV_H_ALLOW__ +#include "qemu_monitor_priv.h" + #define VIR_FROM_THIS VIR_FROM_QEMU VIR_LOG_INIT("qemu.qemu_monitor"); @@ -1037,6 +1040,14 @@ qemuMonitorNextCommandID(qemuMonitorPtr mon) } +/* for use only in the test suite */ +void +qemuMonitorResetCommandID(qemuMonitorPtr mon) +{ + mon->nextSerial =3D 0; +} + + int qemuMonitorSend(qemuMonitorPtr mon, qemuMonitorMessagePtr msg) diff --git a/src/qemu/qemu_monitor_priv.h b/src/qemu/qemu_monitor_priv.h new file mode 100644 index 0000000000..45bda27c0f --- /dev/null +++ b/src/qemu/qemu_monitor_priv.h @@ -0,0 +1,31 @@ +/* + * qemu_monitor_priv.h: interaction with QEMU monitor console (private) + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * . + */ + +#ifndef __QEMU_MONITOR_PRIV_H_ALLOW__ +# error "qemu_monitor_priv.h may only be included by qemu_monitor.c or tes= t suites" +#endif + +#ifndef __QEMU_MONITOR_PRIV_H__ +# define __QEMU_MONITOR_PRIV_H__ + +# include "qemu_monitor.h" + +void +qemuMonitorResetCommandID(qemuMonitorPtr mon); + +#endif --=20 2.16.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list