From nobody Wed May 14 16:17:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520871715720522.9789875007199; Mon, 12 Mar 2018 09:21:55 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 992BE28207; Mon, 12 Mar 2018 16:21:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 21D795C88A; Mon, 12 Mar 2018 16:21:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A98FF181BA00; Mon, 12 Mar 2018 16:21:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CGLoxc024943 for ; Mon, 12 Mar 2018 12:21:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id C5D12215CDAC; Mon, 12 Mar 2018 16:21:50 +0000 (UTC) Received: from antique-work.brq.redhat.com (unknown [10.43.2.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CD27215CDA7 for ; Mon, 12 Mar 2018 16:21:50 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:21:32 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 02/18] util: there is no need to mark cleanup functions as inline X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 12 Mar 2018 16:21:54 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- src/util.c | 34 ++++++++++++++++++++++++++++++++++ src/util.h | 38 ++++++++------------------------------ 2 files changed, 42 insertions(+), 30 deletions(-) diff --git a/src/util.c b/src/util.c index d0649fa..962eaab 100644 --- a/src/util.c +++ b/src/util.c @@ -104,6 +104,40 @@ virtDBusUtilVirDomainFromBusPath(virConnectPtr connect= ion, return virDomainLookupByUUIDString(connection, name); } =20 +void +virtDBusUtilFreep(void *p) +{ + free(*(void **)p); +} + +void +virtDBusUtilClosep(int *fdp) +{ + if (*fdp >=3D 0) + close(*fdp); +} + +void +virtDBusUtilStrvFreep(void *p) +{ + char **strv =3D *(char ***)p; + + if (strv =3D=3D NULL) + return; + + for (unsigned i =3D 0; strv[i] !=3D NULL; i++) + free(strv[i]); + + free(strv); +} + +void +virtDBusUtilVirDomainFreep(virDomainPtr *domainp) +{ + if (*domainp) + virDomainFree(*domainp); +} + void virtDBusUtilVirDomainListFreep(virDomainPtr **domainsp) { diff --git a/src/util.h b/src/util.h index 9779d29..a772ffe 100644 --- a/src/util.h +++ b/src/util.h @@ -33,39 +33,17 @@ virtDBusUtilVirDomainFromBusPath(virConnectPtr connecti= on, const char *path, const char *domainPath); =20 -static inline void -virtDBusUtilFreep(void *p) -{ - free(*(void **)p); -} - -static inline void -virtDBusUtilClosep(int *fdp) -{ - if (*fdp >=3D 0) - close(*fdp); -} - -static inline void -virtDBusUtilStrvFreep(void *p) -{ - char **strv =3D *(char ***)p; - - if (strv =3D=3D NULL) - return; +void +virtDBusUtilFreep(void *p); =20 - for (unsigned i =3D 0; strv[i] !=3D NULL; i +=3D 1) - free(strv[i]); +void +virtDBusUtilClosep(int *fdp); =20 - free(strv); -} +void +virtDBusUtilStrvFreep(void *p); =20 -static inline void -virtDBusUtilVirDomainFreep(virDomainPtr *domainp) -{ - if (*domainp) - virDomainFree(*domainp); -} +void +virtDBusUtilVirDomainFreep(virDomainPtr *domainp); =20 void virtDBusUtilVirDomainListFreep(virDomainPtr **domainsp); --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list