From nobody Wed May 14 13:58:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1523782359936572.1836947821861; Sun, 15 Apr 2018 01:52:39 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 82ACA821C7; Sun, 15 Apr 2018 08:52:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5347C649AC; Sun, 15 Apr 2018 08:52:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 12034B34B3; Sun, 15 Apr 2018 08:52:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3DElMCd012343 for ; Fri, 13 Apr 2018 10:47:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2E8CF2026E0E; Fri, 13 Apr 2018 14:47:22 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA6A42026DFD for ; Fri, 13 Apr 2018 14:47:21 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Fri, 13 Apr 2018 16:47:12 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 5/9] src: Unify dispose function names X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sun, 15 Apr 2018 08:52:39 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" If a function is disposing virSomething it should be called virSomethingDispose(). There are two offenders: virCapabilitiesDispose(virCapsPtr) and virDomainXMLOptionClassDispose(virDomainXMLOptionPtr). Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/conf/capabilities.c | 6 +++--- src/conf/domain_conf.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index edf9f54f77..33b9194041 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -58,14 +58,14 @@ VIR_ENUM_IMPL(virCapsHostPMTarget, VIR_NODE_SUSPEND_TAR= GET_LAST, "suspend_mem", "suspend_disk", "suspend_hybrid"); =20 static virClassPtr virCapsClass; -static void virCapabilitiesDispose(void *obj); +static void virCapsDispose(void *obj); =20 static int virCapabilitiesOnceInit(void) { if (!(virCapsClass =3D virClassNew(virClassForObject(), "virCaps", sizeof(virCaps), - virCapabilitiesDispose))) + virCapsDispose))) return -1; =20 return 0; @@ -215,7 +215,7 @@ virCapabilitiesClearSecModel(virCapsHostSecModelPtr sec= model) } =20 static void -virCapabilitiesDispose(void *object) +virCapsDispose(void *object) { virCapsPtr caps =3D object; size_t i; diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d23182f18a..4dad8e3b20 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -934,7 +934,7 @@ VIR_ENUM_IMPL(virDomainShmemModel, VIR_DOMAIN_SHMEM_MOD= EL_LAST, static virClassPtr virDomainObjClass; static virClassPtr virDomainXMLOptionClass; static void virDomainObjDispose(void *obj); -static void virDomainXMLOptionClassDispose(void *obj); +static void virDomainXMLOptionDispose(void *obj); =20 static int virDomainObjOnceInit(void) { @@ -947,7 +947,7 @@ static int virDomainObjOnceInit(void) if (!(virDomainXMLOptionClass =3D virClassNew(virClassForObject(), "virDomainXMLOption", sizeof(virDomainXMLOption), - virDomainXMLOptionClassDis= pose))) + virDomainXMLOptionDispose)= )) return -1; =20 return 0; @@ -957,7 +957,7 @@ VIR_ONCE_GLOBAL_INIT(virDomainObj) =20 =20 static void -virDomainXMLOptionClassDispose(void *obj) +virDomainXMLOptionDispose(void *obj) { virDomainXMLOptionPtr xmlopt =3D obj; =20 --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list