From nobody Wed May 14 06:29:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526024798524990.3768858387162; Fri, 11 May 2018 00:46:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC33C7EBC2; Fri, 11 May 2018 07:46:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B7D9201634D; Fri, 11 May 2018 07:46:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0A440180B5B1; Fri, 11 May 2018 07:46:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4B7kQkp017098 for ; Fri, 11 May 2018 03:46:26 -0400 Received: by smtp.corp.redhat.com (Postfix) id 345C61002940; Fri, 11 May 2018 07:46:26 +0000 (UTC) Received: from antique-laptop.redhat.com (unknown [10.40.205.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id C08A913D2D1E for ; Fri, 11 May 2018 07:46:25 +0000 (UTC) From: Pavel Hrdina To: libvir-list@redhat.com Date: Fri, 11 May 2018 09:46:18 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 4/5] domain: Implement GetVcpuPinInfo method X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 11 May 2018 07:46:37 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- data/org.libvirt.Domain.xml | 6 ++++ src/domain.c | 59 +++++++++++++++++++++++++++++++++++++ tests/test_domain.py | 9 ++++++ 3 files changed, 74 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 6c48e9d..3f6e8d8 100644 --- a/data/org.libvirt.Domain.xml +++ b/data/org.libvirt.Domain.xml @@ -312,6 +312,12 @@ + + + + + diff --git a/src/domain.c b/src/domain.c index d07e0a7..274d385 100644 --- a/src/domain.c +++ b/src/domain.c @@ -1686,6 +1686,64 @@ virtDBusDomainGetTime(GVariant *inArgs, *outArgs =3D g_variant_new("((tu))", seconds, nseconds); } =20 +static void +virtDBusDomainGetVcpuPinInfo(GVariant *inArgs, + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath, + gpointer userData, + GVariant **outArgs, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) + +{ + virtDBusConnect *connect =3D userData; + g_autoptr(virDomain) domain =3D NULL; + guint flags; + virDomainInfo domInfo; + gint vcpuCount; + gint cpuCount; + g_autofree guchar *cpumaps =3D NULL; + gint cpumaplen; + GVariantBuilder builder; + GVariant *gret; + + g_variant_get(inArgs, "(u)", &flags); + + domain =3D virtDBusDomainGetVirDomain(connect, objectPath, error); + if (!domain) + return; + + if (virDomainGetInfo(domain, &domInfo) < 0) + return virtDBusUtilSetLastVirtError(error); + + vcpuCount =3D domInfo.nrVirtCpu; + + cpuCount =3D virNodeGetCPUMap(connect->connection, NULL, NULL, 0); + if (cpuCount < 0) + return virtDBusUtilSetLastVirtError(error); + + cpumaplen =3D VIR_CPU_MAPLEN(cpuCount); + cpumaps =3D g_new0(guchar, cpumaplen * vcpuCount); + + if (virDomainGetVcpuPinInfo(domain, vcpuCount, cpumaps, + cpumaplen, flags) < 0) { + return virtDBusUtilSetLastVirtError(error); + } + + g_variant_builder_init(&builder, G_VARIANT_TYPE("aab")); + for (gint i =3D 0; i < vcpuCount; i++) { + g_variant_builder_open(&builder, G_VARIANT_TYPE("ab")); + for (gint j =3D 0; j < cpuCount; j++) { + g_variant_builder_add(&builder, "b", + VIR_CPU_USABLE(cpumaps, cpumaplen, i, j)= ); + } + g_variant_builder_close(&builder); + } + gret =3D g_variant_builder_end(&builder); + + *outArgs =3D g_variant_new_tuple(&gret, 1); +} + static void virtDBusDomainGetVcpus(GVariant *inArgs, GUnixFDList *inFDs G_GNUC_UNUSED, @@ -3024,6 +3082,7 @@ static virtDBusGDBusMethodTable virtDBusDomainMethodT= able[] =3D { { "GetSecurityLabelList", virtDBusDomainGetSecurityLabelList }, { "GetStats", virtDBusDomainGetStats }, { "GetTime", virtDBusDomainGetTime }, + { "GetVcpuPinInfo", virtDBusDomainGetVcpuPinInfo }, { "GetVcpus", virtDBusDomainGetVcpus }, { "GetXMLDesc", virtDBusDomainGetXMLDesc }, { "HasManagedSaveImage", virtDBusDomainHasManagedSaveImage }, diff --git a/tests/test_domain.py b/tests/test_domain.py index dfa19ed..00f282f 100755 --- a/tests/test_domain.py +++ b/tests/test_domain.py @@ -151,6 +151,15 @@ class TestDomain(libvirttest.BaseTestClass): domain.SetVcpus(vcpus_expected, 0) assert domain.GetVcpus(0) =3D=3D dbus.Int32(vcpus_expected) =20 + def test_domain_vcpu_pin_info(self): + obj, domain =3D self.domain() + pinInfo_expected =3D [ + [ True, True, True, True, True, True, True, True ], + [ True, True, True, True, True, True, True, True ] + ] + pinInfo =3D domain.GetVcpuPinInfo(0) + assert pinInfo =3D=3D pinInfo_expected + =20 if __name__ =3D=3D '__main__': libvirttest.run() --=20 2.17.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list