From nobody Thu May 15 07:06:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1512974241454888.4266367510475; Sun, 10 Dec 2017 22:37:21 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 90600C119CB2; Mon, 11 Dec 2017 06:37:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6DB53600D5; Mon, 11 Dec 2017 06:37:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 314D21800FC4; Mon, 11 Dec 2017 06:37:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vBB6ZBWl012841 for ; Mon, 11 Dec 2017 01:35:11 -0500 Received: by smtp.corp.redhat.com (Postfix) id 935B217C70; Mon, 11 Dec 2017 06:35:11 +0000 (UTC) Received: from localhost.localdomain (ovpn-204-41.brq.redhat.com [10.40.204.41]) by smtp.corp.redhat.com (Postfix) with ESMTP id C81B92A307; Mon, 11 Dec 2017 06:35:10 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 11 Dec 2017 07:34:56 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: eskultet@redhat.com Subject: [libvirt] [libvirt-php][PATCH 2/5] src: Don't leak @uuid in libvirt_nwfilter_get_uuid_string X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 11 Dec 2017 06:37:20 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" VIRT_RETURN_STRING() does immediate return. Therefore, efree(uuid) is never called and thus leaked. Moreover, there's no reason for dynamically allocated uuid buffer (in contrast to our misuse of large static buffers). Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/libvirt-nwfilter.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libvirt-nwfilter.c b/src/libvirt-nwfilter.c index cd082a5..1b5dbdc 100644 --- a/src/libvirt-nwfilter.c +++ b/src/libvirt-nwfilter.c @@ -145,12 +145,11 @@ PHP_FUNCTION(libvirt_nwfilter_get_uuid_string) { php_libvirt_nwfilter *nwfilter =3D NULL; zval *znwfilter; - char *uuid =3D NULL; + char uuid[VIR_UUID_STRING_BUFLEN]; int ret =3D -1; =20 GET_NWFILTER_FROM_ARGS("r", &znwfilter); =20 - uuid =3D (char *) emalloc(VIR_UUID_STRING_BUFLEN); ret =3D virNWFilterGetUUIDString(nwfilter->nwfilter, uuid); =20 DPRINTF("%s: virNWFilterGetUUIDString(%p) returned %d (%s)\n", PHPFUNC, @@ -160,7 +159,6 @@ PHP_FUNCTION(libvirt_nwfilter_get_uuid_string) RETURN_FALSE; =20 VIRT_RETURN_STRING(uuid); - efree(uuid); } =20 /* --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list