Note that the waiting thread is singalled in the debug logs to simplify
debugging.
---
 src/qemu/qemu_hotplug.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 0c0885695..889f110a9 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -4362,6 +4362,7 @@ qemuDomainSignalDeviceRemoval(virDomainObjPtr vm,
     qemuDomainObjPrivatePtr priv = vm->privateData;

     if (STREQ_NULLABLE(priv->unplug.alias, devAlias)) {
+        VIR_DEBUG("Removal of device '%s' continues in waiting thread", devAlias);
         qemuDomainResetDeviceRemoval(vm);
         priv->unplug.status = status;
         virDomainObjBroadcast(vm);
-- 
2.12.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, Mar 03, 2017 at 04:11 PM +0100, Peter Krempa <pkrempa@redhat.com> wrote:
> Note that the waiting thread is singalled in the debug logs to simplify

s/singalled/signaled

> debugging.
> ---
>  src/qemu/qemu_hotplug.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
> index 0c0885695..889f110a9 100644
> --- a/src/qemu/qemu_hotplug.c
> +++ b/src/qemu/qemu_hotplug.c
> @@ -4362,6 +4362,7 @@ qemuDomainSignalDeviceRemoval(virDomainObjPtr vm,
>      qemuDomainObjPrivatePtr priv = vm->privateData;
>
>      if (STREQ_NULLABLE(priv->unplug.alias, devAlias)) {
> +        VIR_DEBUG("Removal of device '%s' continues in waiting thread", devAlias);
>          qemuDomainResetDeviceRemoval(vm);
>          priv->unplug.status = status;
>          virDomainObjBroadcast(vm);
> --
> 2.12.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
--
Beste Grüße / Kind regards
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, Mar 03, 2017 at 16:11:49 +0100, Peter Krempa wrote:
> Note that the waiting thread is singalled in the debug logs to simplify

s/sing/sign/ as noted by Marc. The double L may be OK depending on which
side of the Atlantic Ocean is closer to your heart :-)

ACK

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, Mar 10, 2017 at 08:50:48 +0100, Jiri Denemark wrote:
> On Fri, Mar 03, 2017 at 16:11:49 +0100, Peter Krempa wrote:
> > Note that the waiting thread is singalled in the debug logs to simplify
> 
> s/sing/sign/ as noted by Marc. The double L may be OK depending on which
> side of the Atlantic Ocean is closer to your heart :-)

I used the spelling pointed out by Marc. I refuse to accept that it
reflects my preferred side of the Atlantic :)

Thanks

Peter
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list