[libvirt] [PATCH v4 3/3] news: Update news and libvirt documentation

Farhan Ali posted 3 patches 7 years, 11 months ago
There is a newer version of this series
[libvirt] [PATCH v4 3/3] news: Update news and libvirt documentation
Posted by Farhan Ali 7 years, 11 months ago
Update news and libvirt docs for loadparm.

Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
---
 docs/formatdomain.html.in |  9 +++++++--
 docs/news.xml             | 11 +++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 07208ee..837be18 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -3022,8 +3022,13 @@
       <dt><code>boot</code></dt>
       <dd>Specifies that the disk is bootable. The <code>order</code>
         attribute determines the order in which devices will be tried during
-        boot sequence. The per-device <code>boot</code> elements cannot be
-        used together with general boot elements in
+        boot sequence. On S390 architecture only the first boot device is used.
+        The optional <code>loadparm</code> attribute is an 8 byte parameter
+        which can be queried by guests on S390 via sclp or diag 308. Linux
+        guests on S390 can use <code>loadparm</code> to select a boot entry.
+        <span class="since">Since 3.5.0</span>
+        The per-device <code>boot</code> elements cannot be used together
+        with general boot elements in
         <a href="#elementsOSBIOS">BIOS bootloader</a> section.
         <span class="since">Since 0.8.8</span>
       </dd>
diff --git a/docs/news.xml b/docs/news.xml
index 649350a..a15edb5 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -37,6 +37,17 @@
     <section title="New features">
       <change>
         <summary>
+          qemu: Add support for loadparm for a boot device
+        </summary>
+        <description>
+          Add an optional boot parameter 'loadparm' for a boot device.
+          Loadparm is an 8 byte parameter that, when present, is queried by
+          S390 guests via sclp or diag 308. Linux guests on S390 use it to
+          select a boot entry.
+        </description>
+      </change>
+      <change>
+        <summary>
           Improved streams to efficiently transfer sparseness
         </summary>
         <description>
-- 
1.9.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v4 3/3] news: Update news and libvirt documentation
Posted by Peter Krempa 7 years, 11 months ago
On Wed, May 31, 2017 at 11:25:41 -0400, Farhan Ali wrote:
> Update news and libvirt docs for loadparm.
> 
> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
> ---
>  docs/formatdomain.html.in |  9 +++++++--
>  docs/news.xml             | 11 +++++++++++
>  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 07208ee..837be18 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -3022,8 +3022,13 @@
>        <dt><code>boot</code></dt>
>        <dd>Specifies that the disk is bootable. The <code>order</code>
>          attribute determines the order in which devices will be tried during
> -        boot sequence. The per-device <code>boot</code> elements cannot be
> -        used together with general boot elements in
> +        boot sequence. On S390 architecture only the first boot device is used.
> +        The optional <code>loadparm</code> attribute is an 8 byte parameter
> +        which can be queried by guests on S390 via sclp or diag 308. Linux
> +        guests on S390 can use <code>loadparm</code> to select a boot entry.
> +        <span class="since">Since 3.5.0</span>
> +        The per-device <code>boot</code> elements cannot be used together
> +        with general boot elements in
>          <a href="#elementsOSBIOS">BIOS bootloader</a> section.
>          <span class="since">Since 0.8.8</span>
>        </dd>

Okay, so this should be in the first patch.

> diff --git a/docs/news.xml b/docs/news.xml
> index 649350a..a15edb5 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -37,6 +37,17 @@
>      <section title="New features">
>        <change>
>          <summary>
> +          qemu: Add support for loadparm for a boot device
> +        </summary>
> +        <description>
> +          Add an optional boot parameter 'loadparm' for a boot device.
> +          Loadparm is an 8 byte parameter that, when present, is queried by
> +          S390 guests via sclp or diag 308. Linux guests on S390 use it to
> +          select a boot entry.
> +        </description>
> +      </change>
> +      <change>
> +        <summary>
>            Improved streams to efficiently transfer sparseness
>          </summary>
>          <description>

Our contributor guidelines state that this change has to be in a
separate patch.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v4 3/3] news: Update news and libvirt documentation
Posted by Farhan Ali 7 years, 11 months ago
Hi Peter,

Thanks for reviewing the patches. I will post another patch series with 
the changes you requested.

Thanks
Farhan

On 06/01/2017 02:39 AM, Peter Krempa wrote:
> On Wed, May 31, 2017 at 11:25:41 -0400, Farhan Ali wrote:
>> Update news and libvirt docs for loadparm.
>>
>> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
>> ---
>>  docs/formatdomain.html.in |  9 +++++++--
>>  docs/news.xml             | 11 +++++++++++
>>  2 files changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>> index 07208ee..837be18 100644
>> --- a/docs/formatdomain.html.in
>> +++ b/docs/formatdomain.html.in
>> @@ -3022,8 +3022,13 @@
>>        <dt><code>boot</code></dt>
>>        <dd>Specifies that the disk is bootable. The <code>order</code>
>>          attribute determines the order in which devices will be tried during
>> -        boot sequence. The per-device <code>boot</code> elements cannot be
>> -        used together with general boot elements in
>> +        boot sequence. On S390 architecture only the first boot device is used.
>> +        The optional <code>loadparm</code> attribute is an 8 byte parameter
>> +        which can be queried by guests on S390 via sclp or diag 308. Linux
>> +        guests on S390 can use <code>loadparm</code> to select a boot entry.
>> +        <span class="since">Since 3.5.0</span>
>> +        The per-device <code>boot</code> elements cannot be used together
>> +        with general boot elements in
>>          <a href="#elementsOSBIOS">BIOS bootloader</a> section.
>>          <span class="since">Since 0.8.8</span>
>>        </dd>
>
> Okay, so this should be in the first patch.
>
>> diff --git a/docs/news.xml b/docs/news.xml
>> index 649350a..a15edb5 100644
>> --- a/docs/news.xml
>> +++ b/docs/news.xml
>> @@ -37,6 +37,17 @@
>>      <section title="New features">
>>        <change>
>>          <summary>
>> +          qemu: Add support for loadparm for a boot device
>> +        </summary>
>> +        <description>
>> +          Add an optional boot parameter 'loadparm' for a boot device.
>> +          Loadparm is an 8 byte parameter that, when present, is queried by
>> +          S390 guests via sclp or diag 308. Linux guests on S390 use it to
>> +          select a boot entry.
>> +        </description>
>> +      </change>
>> +      <change>
>> +        <summary>
>>            Improved streams to efficiently transfer sparseness
>>          </summary>
>>          <description>
>
> Our contributor guidelines state that this change has to be in a
> separate patch.
>
>
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list