It's obvious that unsigned long long is 64 bit and also our web page
generator would misplace the comment after the return value due to the
way it's parsing them.
---
 src/libvirt-domain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 9bda3c204..4033ae8e6 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -5820,7 +5820,7 @@ virDomainMemoryStats(virDomainPtr dom, virDomainMemoryStatPtr stats,
 int
 virDomainBlockPeek(virDomainPtr dom,
                    const char *disk,
-                   unsigned long long offset /* really 64 bits */,
+                   unsigned long long offset,
                    size_t size,
                    void *buffer,
                    unsigned int flags)
@@ -5956,7 +5956,7 @@ virDomainBlockResize(virDomainPtr dom,
  */
 int
 virDomainMemoryPeek(virDomainPtr dom,
-                    unsigned long long start /* really 64 bits */,
+                    unsigned long long start,
                     size_t size,
                     void *buffer,
                     unsigned int flags)
-- 
2.12.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 06/23/2017 09:33 AM, Peter Krempa wrote:
> It's obvious that unsigned long long is 64 bit and also our web page
> generator would misplace the comment after the return value due to the
> way it's parsing them.
> ---
>  src/libvirt-domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

(this one's safe for freeze if you care, but the rest should wait for
after release)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Sat, Jul 01, 2017 at 10:41:24 -0400, John Ferlan wrote:
> 
> 
> On 06/23/2017 09:33 AM, Peter Krempa wrote:
> > It's obvious that unsigned long long is 64 bit and also our web page
> > generator would misplace the comment after the return value due to the
> > way it's parsing them.
> > ---
> >  src/libvirt-domain.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> 
> Reviewed-by: John Ferlan <jferlan@redhat.com>
> 
> John
> 
> (this one's safe for freeze if you care, but the rest should wait for
> after release)

I've pushed this one so that the docs embedded in the upcomming release
are already fixed.

Thanks.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list