[libvirt] [PATCH 2/2] news: Add CAT capability information into improvements

Martin Kletzander posted 2 patches 7 years, 10 months ago
[libvirt] [PATCH 2/2] news: Add CAT capability information into improvements
Posted by Martin Kletzander 7 years, 10 months ago
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 docs/news.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 72405ec92289..488e3025fbbf 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -57,6 +57,16 @@
       </change>
     </section>
     <section title="Improvements">
+      <change>
+        <summary>
+          Capabilities now include info about host's CAT settings
+        </summary>
+        <description>
+          Even though it's not usable yet, various information about
+          resource control from the host is gathered and presented in
+          capabilities if available.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
     </section>
-- 
2.13.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] news: Add CAT capability information into improvements
Posted by Peter Krempa 7 years, 10 months ago
On Wed, Jun 28, 2017 at 09:54:02 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  docs/news.xml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 72405ec92289..488e3025fbbf 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -57,6 +57,16 @@
>        </change>
>      </section>
>      <section title="Improvements">
> +      <change>
> +        <summary>
> +          Capabilities now include info about host's CAT settings
> +        </summary>
> +        <description>
> +          Even though it's not usable yet, various information about

Why then advertise it?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] news: Add CAT capability information into improvements
Posted by Martin Kletzander 7 years, 10 months ago
On Wed, Jun 28, 2017 at 11:44:13AM +0200, Peter Krempa wrote:
>On Wed, Jun 28, 2017 at 09:54:02 +0200, Martin Kletzander wrote:
>> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>> ---
>>  docs/news.xml | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/docs/news.xml b/docs/news.xml
>> index 72405ec92289..488e3025fbbf 100644
>> --- a/docs/news.xml
>> +++ b/docs/news.xml
>> @@ -57,6 +57,16 @@
>>        </change>
>>      </section>
>>      <section title="Improvements">
>> +      <change>
>> +        <summary>
>> +          Capabilities now include info about host's CAT settings
>> +        </summary>
>> +        <description>
>> +          Even though it's not usable yet, various information about
>
>Why then advertise it?

I chose the wrong words.  How about if I leave out the "Even though it's
not usable yet, " at all or (another version) say "Domain threads cannot
be allocated using the XML yet, however " instead of that part?

>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] news: Add CAT capability information into improvements
Posted by Peter Krempa 7 years, 10 months ago
On Wed, Jun 28, 2017 at 12:26:48 +0200, Martin Kletzander wrote:
> On Wed, Jun 28, 2017 at 11:44:13AM +0200, Peter Krempa wrote:
> >On Wed, Jun 28, 2017 at 09:54:02 +0200, Martin Kletzander wrote:
> >> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> >> ---
> >>  docs/news.xml | 10 ++++++++++
> >>  1 file changed, 10 insertions(+)
> >>
> >> diff --git a/docs/news.xml b/docs/news.xml
> >> index 72405ec92289..488e3025fbbf 100644
> >> --- a/docs/news.xml
> >> +++ b/docs/news.xml
> >> @@ -57,6 +57,16 @@
> >>        </change>
> >>      </section>
> >>      <section title="Improvements">
> >> +      <change>
> >> +        <summary>
> >> +          Capabilities now include info about host's CAT settings
> >> +        </summary>
> >> +        <description>
> >> +          Even though it's not usable yet, various information about
> >
> >Why then advertise it?
> 
> I chose the wrong words.  How about if I leave out the "Even though it's
> not usable yet, " at all or (another version) say "Domain threads cannot
> be allocated using the XML yet, however " instead of that part?

Dropping the first part will be the best. ACK to that
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list