[libvirt] [PATCH 3/7] qemu: Rename qemuProcessUpdateLiveGuestCPU

Jiri Denemark posted 7 patches 8 years, 5 months ago
[libvirt] [PATCH 3/7] qemu: Rename qemuProcessUpdateLiveGuestCPU
Posted by Jiri Denemark 8 years, 5 months ago
In addition to updating a guest CPU definition the function verifies
that all required features are provided to the guest. Let's make it
obvious by calling it qemuProcessUpdateAndVerifyCPU.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/qemu/qemu_process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 198f68d93..ebd13057b 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -4011,7 +4011,7 @@ qemuProcessVerifyCPU(virDomainObjPtr vm,
 
 
 static int
-qemuProcessUpdateLiveGuestCPU(virQEMUDriverPtr driver,
+qemuProcessUpdateAndVerifyCPU(virQEMUDriverPtr driver,
                               virDomainObjPtr vm,
                               qemuDomainAsyncJob asyncJob)
 {
@@ -5928,7 +5928,7 @@ qemuProcessLaunch(virConnectPtr conn,
         goto cleanup;
 
     VIR_DEBUG("Verifying and updating provided guest CPU");
-    if (qemuProcessUpdateLiveGuestCPU(driver, vm, asyncJob) < 0)
+    if (qemuProcessUpdateAndVerifyCPU(driver, vm, asyncJob) < 0)
         goto cleanup;
 
     VIR_DEBUG("Setting up post-init cgroup restrictions");
-- 
2.13.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 3/7] qemu: Rename qemuProcessUpdateLiveGuestCPU
Posted by Pavel Hrdina 8 years, 5 months ago
On Wed, Jul 12, 2017 at 02:56:49PM +0200, Jiri Denemark wrote:
> In addition to updating a guest CPU definition the function verifies
> that all required features are provided to the guest. Let's make it
> obvious by calling it qemuProcessUpdateAndVerifyCPU.
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/qemu/qemu_process.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list