[libvirt] [PATCH 4/8] qemuDomainObjPrivateFree: Free @machineName

Michal Privoznik posted 8 patches 7 years, 9 months ago
[libvirt] [PATCH 4/8] qemuDomainObjPrivateFree: Free @machineName
Posted by Michal Privoznik 7 years, 9 months ago
We're storing the machine name in @priv but free it just in
qemuProcessStop, Therefore this may leak.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_domain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index fe27e1122..40608554c 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1722,6 +1722,7 @@ qemuDomainObjPrivateFree(void *data)
     virBitmapFree(priv->autoNodeset);
     virBitmapFree(priv->autoCpuset);
 
+    VIR_FREE(priv->machineName);
     VIR_FREE(priv->libDir);
     VIR_FREE(priv->channelTargetDir);
 
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/8] qemuDomainObjPrivateFree: Free @machineName
Posted by Peter Krempa 7 years, 9 months ago
On Fri, Aug 04, 2017 at 16:22:32 +0200, Michal Privoznik wrote:
> We're storing the machine name in @priv but free it just in
> qemuProcessStop, Therefore this may leak.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/qemu/qemu_domain.c | 1 +
>  1 file changed, 1 insertion(+)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list