[libvirt] [PATCH 3/8] virNodeDevCapCCWParseXML: Free temporary variables

Michal Privoznik posted 8 patches 8 years, 4 months ago
[libvirt] [PATCH 3/8] virNodeDevCapCCWParseXML: Free temporary variables
Posted by Michal Privoznik 8 years, 4 months ago
Again, we are using @cssid, @ssid and @devno to store some
temporary strings, but never free it.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/conf/node_device_conf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 82f02fa6c..726bf042c 100644
--- a/src/conf/node_device_conf.c
+++ b/src/conf/node_device_conf.c
@@ -792,6 +792,9 @@ virNodeDevCapCCWParseXML(xmlXPathContextPtr ctxt,
 
  out:
     ctxt->node = orignode;
+    VIR_FREE(cssid);
+    VIR_FREE(ssid);
+    VIR_FREE(devno);
     return ret;
 }
 
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 3/8] virNodeDevCapCCWParseXML: Free temporary variables
Posted by Peter Krempa 8 years, 4 months ago
On Fri, Aug 04, 2017 at 16:22:31 +0200, Michal Privoznik wrote:
> Again, we are using @cssid, @ssid and @devno to store some
> temporary strings, but never free it.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/conf/node_device_conf.c | 3 +++
>  1 file changed, 3 insertions(+)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list