In virDomainNetDefParseXML() the def->coalesce is parsed and
allocated by virDomainNetDefCoalesceParseXML() but in fact it's
never freed .

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/conf/domain_conf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b5ce2ecd9..b487ff2fd 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2040,6 +2040,7 @@ virDomainNetDefClear(virDomainNetDefPtr def)
     VIR_FREE(def->ifname_guest);
     VIR_FREE(def->ifname_guest_actual);
     VIR_FREE(def->virtio);
+    VIR_FREE(def->coalesce);
 
     virNetDevIPInfoClear(&def->guestIP);
     virNetDevIPInfoClear(&def->hostIP);
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, Aug 10, 2017 at 09:29:06AM +0200, Michal Privoznik wrote:
>In virDomainNetDefParseXML() the def->coalesce is parsed and
>allocated by virDomainNetDefCoalesceParseXML() but in fact it's
>never freed .
>

s/d \./d./

>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/conf/domain_conf.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index b5ce2ecd9..b487ff2fd 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -2040,6 +2040,7 @@ virDomainNetDefClear(virDomainNetDefPtr def)
>     VIR_FREE(def->ifname_guest);
>     VIR_FREE(def->ifname_guest_actual);
>     VIR_FREE(def->virtio);
>+    VIR_FREE(def->coalesce);
>
>     virNetDevIPInfoClear(&def->guestIP);
>     virNetDevIPInfoClear(&def->hostIP);
>--
>2.13.0
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list