qemu: don't lose VMs if emulator is not installed

[libvirt] [PATCH 01/12] conf: domainlist: Explicitly report failure to load domain config

Posted by Peter Krempa 7 years, 9 months ago

When dropping a domain report which one was dropped so that it's not
necessary to rummage through the logs.
---
 src/conf/virdomainobjlist.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/conf/virdomainobjlist.c b/src/conf/virdomainobjlist.c
index d874133a7..a8b3f4124 100644
--- a/src/conf/virdomainobjlist.c
+++ b/src/conf/virdomainobjlist.c
@@ -605,6 +605,8 @@ virDomainObjListLoadAllConfigs(virDomainObjListPtr doms,
             if (!liveStatus)
                 dom->persistent = 1;
             virObjectUnlock(dom);
+        } else {
+            VIR_ERROR(_("Failed to load config for domain '%s'"), entry->d_name);
         }
     }

-- 
2.14.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/12] conf: domainlist: Explicitly report failure to load domain config

Posted by Ján Tomko 7 years, 9 months ago

On Wed, Aug 16, 2017 at 04:57:50PM +0200, Peter Krempa wrote:
>When dropping a domain report which one was dropped so that it's not
>necessary to rummage through the logs.
>---
> src/conf/virdomainobjlist.c | 2 ++
> 1 file changed, 2 insertions(+)
>

ACK

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list