1. Patchew
  2. Libvirt
  3. [libvirt] [PATCH 0/5] introduce reconnect feature for chardev devices
  4. View patch

[libvirt] [PATCH 1/5] qemu: introduce QEMU_CAPS_CHARDEV_RECONNECT

Pavel Hrdina posted 5 patches 7 years, 8 months ago
[libvirt] [PATCH 1/5] qemu: introduce QEMU_CAPS_CHARDEV_RECONNECT
Posted by Pavel Hrdina 7 years, 8 months ago 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/qemu/qemu_capabilities.c                            | 2 ++
 src/qemu/qemu_capabilities.h                            | 1 +
 tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml        | 1 +
 tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml        | 1 +
 tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml       | 1 +
 tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml        | 1 +
 tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml         | 1 +
 tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml        | 1 +
 tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml         | 1 +
 tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml        | 1 +
 tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml       | 1 +
 tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml         | 1 +
 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml        | 1 +
 15 files changed, 16 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 38a9f09f53..fa8d026b21 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -437,6 +437,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
               "spapr-pci-host-bridge.numa_node",
               "vnc-multi-servers",
               "virtio-net.tx_queue_size",
+              "chardev-reconnect",
     );
 
 
@@ -3235,6 +3236,7 @@ static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] = {
     { "machine", "kernel_irqchip", QEMU_CAPS_MACHINE_KERNEL_IRQCHIP },
     { "machine", "loadparm", QEMU_CAPS_LOADPARM },
     { "vnc", "vnc", QEMU_CAPS_VNC_MULTI_SERVERS },
+    { "chardev", "reconnect", QEMU_CAPS_CHARDEV_RECONNECT },
 };
 
 static int
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index 8804cc7819..7b59619497 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -423,6 +423,7 @@ typedef enum {
     QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE, /* spapr-pci-host-bridge.numa_node= */
     QEMU_CAPS_VNC_MULTI_SERVERS, /* -vnc vnc=unix:/path */
     QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE, /* virtio-net-*.tx_queue_size */
+    QEMU_CAPS_CHARDEV_RECONNECT, /* -chardev *,reconnect */
 
     QEMU_CAPS_LAST /* this must always be the last item */
 } virQEMUCapsFlags;
diff --git a/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
index 11c8765738..5cd4772fdf 100644
--- a/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
@@ -186,6 +186,7 @@
   <flag name='query-named-block-nodes'/>
   <flag name='kernel-irqchip'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2004000</version>
   <kvmVersion>0</kvmVersion>
   <package></package>
diff --git a/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
index eee1ab24d9..3ad458121b 100644
--- a/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
@@ -192,6 +192,7 @@
   <flag name='query-named-block-nodes'/>
   <flag name='kernel-irqchip'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2005000</version>
   <kvmVersion>0</kvmVersion>
   <package></package>
diff --git a/tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml
index f8746f4c1e..032ffb0810 100644
--- a/tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml
@@ -170,6 +170,7 @@
   <flag name='kernel-irqchip'/>
   <flag name='kernel-irqchip.split'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2006000</version>
   <kvmVersion>0</kvmVersion>
   <package></package>
diff --git a/tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml
index 0ce1c8a333..ce95a325ed 100644
--- a/tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml
@@ -170,6 +170,7 @@
   <flag name='kernel-irqchip'/>
   <flag name='kernel-irqchip.split'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2006000</version>
   <kvmVersion>0</kvmVersion>
   <package></package>
diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml
index 92dba13b06..5f2ddf90d2 100644
--- a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml
+++ b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml
@@ -165,6 +165,7 @@
   <flag name='kernel-irqchip.split'/>
   <flag name='spapr-pci-host-bridge'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2006000</version>
   <kvmVersion>0</kvmVersion>
   <package></package>
diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
index 1937dc9c11..cfe04eda29 100644
--- a/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
@@ -202,6 +202,7 @@
   <flag name='kernel-irqchip'/>
   <flag name='kernel-irqchip.split'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2006000</version>
   <kvmVersion>0</kvmVersion>
   <package></package>
diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
index 1c1aab8dec..81189960eb 100644
--- a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
@@ -132,6 +132,7 @@
   <flag name='kernel-irqchip'/>
   <flag name='kernel-irqchip.split'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2007000</version>
   <kvmVersion>0</kvmVersion>
   <package></package>
diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
index b484411314..a388515bae 100644
--- a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
@@ -205,6 +205,7 @@
   <flag name='kernel-irqchip.split'/>
   <flag name='intel-iommu.intremap'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2007000</version>
   <kvmVersion>0</kvmVersion>
   <package> (v2.7.0)</package>
diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
index 5a326d9881..8b05c091ed 100644
--- a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
@@ -134,6 +134,7 @@
   <flag name='kernel-irqchip'/>
   <flag name='kernel-irqchip.split'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2007093</version>
   <kvmVersion>0</kvmVersion>
   <package></package>
diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
index e31abd4b8b..18119a15be 100644
--- a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
@@ -207,6 +207,7 @@
   <flag name='intel-iommu.intremap'/>
   <flag name='intel-iommu.eim'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2008000</version>
   <kvmVersion>0</kvmVersion>
   <package> (v2.8.0)</package>
diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
index f80bfc434c..7d6af50fc9 100644
--- a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
+++ b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
@@ -170,6 +170,7 @@
   <flag name='spapr-pci-host-bridge'/>
   <flag name='spapr-pci-host-bridge.numa_node'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2009000</version>
   <kvmVersion>0</kvmVersion>
   <package> (v2.9.0)</package>
diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
index bed2c2da93..7db2554d72 100644
--- a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
@@ -135,6 +135,7 @@
   <flag name='virtio.iommu_platform'/>
   <flag name='virtio.ats'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2009000</version>
   <kvmVersion>0</kvmVersion>
   <package></package>
diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
index 2b406704a6..028e596b60 100644
--- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
@@ -218,6 +218,7 @@
   <flag name='virtio.iommu_platform'/>
   <flag name='virtio.ats'/>
   <flag name='vnc-multi-servers'/>
+  <flag name='chardev-reconnect'/>
   <version>2009000</version>
   <kvmVersion>0</kvmVersion>
   <package> (v2.9.0)</package>
-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/5] qemu: introduce QEMU_CAPS_CHARDEV_RECONNECT
Posted by Ján Tomko 7 years, 8 months ago 
On Mon, Aug 28, 2017 at 02:56:49PM +0200, Pavel Hrdina wrote:
>Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>---
> src/qemu/qemu_capabilities.c                            | 2 ++
> src/qemu/qemu_capabilities.h                            | 1 +
> tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml        | 1 +
> tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml        | 1 +
> tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml | 1 +
> tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml | 1 +
> tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml       | 1 +
> tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml        | 1 +
> tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml         | 1 +
> tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml        | 1 +
> tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml         | 1 +
> tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml        | 1 +
> tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml       | 1 +
> tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml         | 1 +
> tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml        | 1 +
> 15 files changed, 16 insertions(+)
>
>diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
>index 8804cc7819..7b59619497 100644
>--- a/src/qemu/qemu_capabilities.h
>+++ b/src/qemu/qemu_capabilities.h
>@@ -423,6 +423,7 @@ typedef enum {
>     QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE, /* spapr-pci-host-bridge.numa_node= */
>     QEMU_CAPS_VNC_MULTI_SERVERS, /* -vnc vnc=unix:/path */
>     QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE, /* virtio-net-*.tx_queue_size */
>+    QEMU_CAPS_CHARDEV_RECONNECT, /* -chardev *,reconnect */

We use a dot to separate the attributes in the rest of the comments.

>
>     QEMU_CAPS_LAST /* this must always be the last item */
> } virQEMUCapsFlags;

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/5] qemu: introduce QEMU_CAPS_CHARDEV_RECONNECT
Posted by Pavel Hrdina 7 years, 8 months ago 
On Mon, Aug 28, 2017 at 03:07:25PM +0200, Ján Tomko wrote:
> On Mon, Aug 28, 2017 at 02:56:49PM +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> > ---
> > src/qemu/qemu_capabilities.c                            | 2 ++
> > src/qemu/qemu_capabilities.h                            | 1 +
> > tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml | 1 +
> > tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml | 1 +
> > tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml       | 1 +
> > tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml         | 1 +
> > tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml         | 1 +
> > tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml        | 1 +
> > tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml       | 1 +
> > tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml         | 1 +
> > tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml        | 1 +
> > 15 files changed, 16 insertions(+)
> > 
> > diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> > index 8804cc7819..7b59619497 100644
> > --- a/src/qemu/qemu_capabilities.h
> > +++ b/src/qemu/qemu_capabilities.h
> > @@ -423,6 +423,7 @@ typedef enum {
> >     QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE, /* spapr-pci-host-bridge.numa_node= */
> >     QEMU_CAPS_VNC_MULTI_SERVERS, /* -vnc vnc=unix:/path */
> >     QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE, /* virtio-net-*.tx_queue_size */
> > +    QEMU_CAPS_CHARDEV_RECONNECT, /* -chardev *,reconnect */
> 
> We use a dot to separate the attributes in the rest of the comments.

We use the dot for devices, this is not a device.  I can change it to
/* -chardev reconnect */.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-8c64711

© 2016 - 2025 Red Hat, Inc.