[libvirt] [PATCH 3/3] qemu: caps: Deprecate QEMU_CAPS_BLOCKJOB_SYNC

Peter Krempa posted 3 patches 7 years, 8 months ago
[libvirt] [PATCH 3/3] qemu: caps: Deprecate QEMU_CAPS_BLOCKJOB_SYNC
Posted by Peter Krempa 7 years, 8 months ago
Interrestingly, none of the qemus we have caps for supported it ...
---
 src/qemu/qemu_capabilities.c | 1 -
 src/qemu/qemu_capabilities.h | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index e7ea6f47c..c690cb349 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -1562,7 +1562,6 @@ struct virQEMUCapsStringFlags {
 struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
     { "system_wakeup", QEMU_CAPS_WAKEUP },
     { "transaction", QEMU_CAPS_TRANSACTION },
-    { "block_stream", QEMU_CAPS_BLOCKJOB_SYNC },
     { "block-stream", QEMU_CAPS_BLOCKJOB_ASYNC },
     { "dump-guest-memory", QEMU_CAPS_DUMP_GUEST_MEMORY },
     { "query-spice", QEMU_CAPS_SPICE },
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index f32687d4a..85c390abf 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -174,7 +174,7 @@ typedef enum {
     QEMU_CAPS_TRANSACTION, /* transaction monitor command */

     /* 90 */
-    QEMU_CAPS_BLOCKJOB_SYNC, /* old block_job_cancel, block_stream */
+    X_QEMU_CAPS_BLOCKJOB_SYNC, /* old block_job_cancel, block_stream */
     QEMU_CAPS_BLOCKJOB_ASYNC, /* new block-job-cancel, block-stream */
     QEMU_CAPS_SCSI_CD, /* -device scsi-cd */
     QEMU_CAPS_IDE_CD, /* -device ide-cd */
-- 
2.14.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 3/3] qemu: caps: Deprecate QEMU_CAPS_BLOCKJOB_SYNC
Posted by Eric Blake 7 years, 8 months ago
On 09/13/2017 08:52 AM, Peter Krempa wrote:
> Interrestingly, none of the qemus we have caps for supported it ...

s/Interrestingly/Interestingly/

> ---
>  src/qemu/qemu_capabilities.c | 1 -
>  src/qemu/qemu_capabilities.h | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list