A few cleanups related to qemuDomainDefFormat*

[libvirt] [PATCH 0/2] A few cleanups related to qemuDomainDefFormat*

Posted by Jiri Denemark 7 years, 7 months ago

Jiri Denemark (2):
  qemu: Fix error checking in qemuDomainDefFormatXMLInternal
  qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy

 src/qemu/qemu_domain.c | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

-- 
2.14.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] A few cleanups related to qemuDomainDefFormat*

Posted by Jiri Denemark 7 years, 7 months ago

On Thu, Sep 21, 2017 at 15:23:06 +0200, Jiri Denemark wrote:
> Jiri Denemark (2):
>   qemu: Fix error checking in qemuDomainDefFormatXMLInternal
>   qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy
> 
>  src/qemu/qemu_domain.c | 16 +++-------------
>  1 file changed, 3 insertions(+), 13 deletions(-)

It looks like the issue you were trying to fix by this series was
addressed in [1] which was pushed an hour ago.

Jirka

[1] https://www.redhat.com/archives/libvir-list/2017-September/msg00517.html

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] A few cleanups related to qemuDomainDefFormat*

Posted by Nikolay Shirokovskiy 7 years, 7 months ago


On 21.09.2017 17:34, Jiri Denemark wrote:
> On Thu, Sep 21, 2017 at 15:23:06 +0200, Jiri Denemark wrote:
>> Jiri Denemark (2):
>>   qemu: Fix error checking in qemuDomainDefFormatXMLInternal
>>   qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy
>>
>>  src/qemu/qemu_domain.c | 16 +++-------------
>>  1 file changed, 3 insertions(+), 13 deletions(-)
> 
> It looks like the issue you were trying to fix by this series was
> addressed in [1] which was pushed an hour ago.
> 
> Jirka
> 
> [1] https://www.redhat.com/archives/libvir-list/2017-September/msg00517.html

Looks like this one is addressed to me and somehow I ran across this message )
True, [1] fixes issues I address in my series. But still please check out
the first patch of that series.

Nikolay

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] A few cleanups related to qemuDomainDefFormat*

Posted by Jiri Denemark 7 years, 7 months ago

On Thu, Sep 21, 2017 at 16:34:24 +0200, Jiri Denemark wrote:
> On Thu, Sep 21, 2017 at 15:23:06 +0200, Jiri Denemark wrote:
> > Jiri Denemark (2):
> >   qemu: Fix error checking in qemuDomainDefFormatXMLInternal
> >   qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy
> > 
> >  src/qemu/qemu_domain.c | 16 +++-------------
> >  1 file changed, 3 insertions(+), 13 deletions(-)
> 
> It looks like the issue you were trying to fix by this series was
> addressed in [1] which was pushed an hour ago.
> 
> Jirka
> 
> [1] https://www.redhat.com/archives/libvir-list/2017-September/msg00517.html

Oops, this was supposed to be a reply to "qemu: don't update cpu
unconditionally for migratable flag" :-)

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] A few cleanups related to qemuDomainDefFormat*

Posted by Ján Tomko 7 years, 7 months ago

On Thu, Sep 21, 2017 at 03:23:06PM +0200, Jiri Denemark wrote:
>Jiri Denemark (2):
>  qemu: Fix error checking in qemuDomainDefFormatXMLInternal
>  qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy
>
> src/qemu/qemu_domain.c | 16 +++-------------
> 1 file changed, 3 insertions(+), 13 deletions(-)
>

ACK series

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list