virStorageSource and backing chain refactors and fixes (blockdev-add saga)

[libvirt] [PATCH 7/9] test: set 'type' field of virStorageSource

Posted by Peter Krempa 7 years, 7 months ago

Set the type so that the iterators will work after upcoming
modification.
---
 tests/virstoragetest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
index ffebd4dc1..ad4514871 100644
--- a/tests/virstoragetest.c
+++ b/tests/virstoragetest.c
@@ -580,6 +580,7 @@ testPathRelativePrepare(void)
     size_t i;

     for (i = 0; i < ARRAY_CARDINALITY(backingchain); i++) {
+        backingchain[i].type = VIR_STORAGE_TYPE_FILE;
         if (i < ARRAY_CARDINALITY(backingchain) - 1)
             backingchain[i].backingStore = &backingchain[i + 1];
         else
-- 
2.14.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 7/9] test: set 'type' field of virStorageSource

Posted by Eric Blake 7 years, 7 months ago

On 10/12/2017 02:07 PM, Peter Krempa wrote:
> Set the type so that the iterators will work after upcoming
> modification.
> ---
>  tests/virstoragetest.c | 1 +
>  1 file changed, 1 insertion(+)

Could almost be squashed to the previous patch; but I'm also fine with
it separate.

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
> index ffebd4dc1..ad4514871 100644
> --- a/tests/virstoragetest.c
> +++ b/tests/virstoragetest.c
> @@ -580,6 +580,7 @@ testPathRelativePrepare(void)
>      size_t i;
> 
>      for (i = 0; i < ARRAY_CARDINALITY(backingchain); i++) {
> +        backingchain[i].type = VIR_STORAGE_TYPE_FILE;
>          if (i < ARRAY_CARDINALITY(backingchain) - 1)
>              backingchain[i].backingStore = &backingchain[i + 1];
>          else
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list