This patch modifies some not yet used test data so that the adding a test using
this data is a clean patch and not an addition of huge file with some
adjustments in small files that will be hidden in the middle of that commit.
These changes include:

- Add system dir in vircaps2xmldata/linux-caches

  Back when data for systems with resctrl support were added they had the
  /sys/fs/system directory put into a system/ subdir of the test and
  /sys/fs/resctrl in a resctrl/ subdir of that test.  However, if we also want a
  negative test for the resctrl (requesting allocation on a system that does not
  support resctrl), we need one a test case with any sensible (with cache info)
  system/ subdir and no resctrl/ one.  Easiest way is to add a
  system -> . symlink into existing test case.

- Change linux-resctrl's schemata for default group

  That way we can fit some allocation in.

- Remove one cache from resctrl-skx's schemata and make some room for
  allocations

  That system already has only one cache, so that file was wrong anyway.  We
  have a version with 2 caches already (linux-resctrl-skx-twocaches), so this
  will also add variety to future tests.

- Add some empty allocation for resctrl-skx

  Just to have slightly more coverage and variety.  We can be sure nothing bad
  happens if such allocation exists in case we have that in the tests.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 tests/vircaps2xmldata/linux-caches/system                      | 1 +
 tests/vircaps2xmldata/linux-resctrl-skx/resctrl/empty/schemata | 0
 tests/vircaps2xmldata/linux-resctrl-skx/resctrl/schemata       | 2 +-
 tests/vircaps2xmldata/linux-resctrl/resctrl/schemata           | 2 +-
 4 files changed, 3 insertions(+), 2 deletions(-)
 create mode 120000 tests/vircaps2xmldata/linux-caches/system
 create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx/resctrl/empty/schemata

diff --git a/tests/vircaps2xmldata/linux-caches/system b/tests/vircaps2xmldata/linux-caches/system
new file mode 120000
index 000000000000..945c9b46d684
--- /dev/null
+++ b/tests/vircaps2xmldata/linux-caches/system
@@ -0,0 +1 @@
+.
\ No newline at end of file
diff --git a/tests/vircaps2xmldata/linux-resctrl-skx/resctrl/empty/schemata b/tests/vircaps2xmldata/linux-resctrl-skx/resctrl/empty/schemata
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/vircaps2xmldata/linux-resctrl-skx/resctrl/schemata b/tests/vircaps2xmldata/linux-resctrl-skx/resctrl/schemata
index 4a4913735386..191081f1db47 100644
--- a/tests/vircaps2xmldata/linux-resctrl-skx/resctrl/schemata
+++ b/tests/vircaps2xmldata/linux-resctrl-skx/resctrl/schemata
@@ -1 +1 @@
-L3:0=7ff;1=7ff
+L3:0=0f0
diff --git a/tests/vircaps2xmldata/linux-resctrl/resctrl/schemata b/tests/vircaps2xmldata/linux-resctrl/resctrl/schemata
index 9b47d25fc72e..c1a765f1e0a7 100644
--- a/tests/vircaps2xmldata/linux-resctrl/resctrl/schemata
+++ b/tests/vircaps2xmldata/linux-resctrl/resctrl/schemata
@@ -1 +1 @@
-L3:0=1ffff;1=1ffff
+L3:0=1ff00;1=1ff0f
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 11/13/2017 03:50 AM, Martin Kletzander wrote:
> This patch modifies some not yet used test data so that the adding a test using
> this data is a clean patch and not an addition of huge file with some
> adjustments in small files that will be hidden in the middle of that commit.
> These changes include:
> 
> - Add system dir in vircaps2xmldata/linux-caches
> 
>   Back when data for systems with resctrl support were added they had the
>   /sys/fs/system directory put into a system/ subdir of the test and
>   /sys/fs/resctrl in a resctrl/ subdir of that test.  However, if we also want a
>   negative test for the resctrl (requesting allocation on a system that does not
>   support resctrl), we need one a test case with any sensible (with cache info)
>   system/ subdir and no resctrl/ one.  Easiest way is to add a
>   system -> . symlink into existing test case.
> 
> - Change linux-resctrl's schemata for default group
> 
>   That way we can fit some allocation in.
> 
> - Remove one cache from resctrl-skx's schemata and make some room for
>   allocations
> 
>   That system already has only one cache, so that file was wrong anyway.  We
>   have a version with 2 caches already (linux-resctrl-skx-twocaches), so this
>   will also add variety to future tests.
> 
> - Add some empty allocation for resctrl-skx
> 
>   Just to have slightly more coverage and variety.  We can be sure nothing bad
>   happens if such allocation exists in case we have that in the tests.
> 
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  tests/vircaps2xmldata/linux-caches/system                      | 1 +
>  tests/vircaps2xmldata/linux-resctrl-skx/resctrl/empty/schemata | 0
>  tests/vircaps2xmldata/linux-resctrl-skx/resctrl/schemata       | 2 +-
>  tests/vircaps2xmldata/linux-resctrl/resctrl/schemata           | 2 +-
>  4 files changed, 3 insertions(+), 2 deletions(-)
>  create mode 120000 tests/vircaps2xmldata/linux-caches/system
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx/resctrl/empty/schemata
> 

And an unbelievably long commit message for what looks like some really
minor changes ;-)

I'm glad you know what the schemata entries mean, because to the
untrained eye - they're just bits of data with no meaning.

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list