[libvirt] [PATCH v2 1/3] virQEMUCapsHasPCIMultiBus: Fix @def type

Michal Privoznik posted 3 patches 7 years, 6 months ago
[libvirt] [PATCH v2 1/3] virQEMUCapsHasPCIMultiBus: Fix @def type
Posted by Michal Privoznik 7 years, 6 months ago
This function only queries domani @def. It doesn't change it.
Therefore it should take const pointer.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_capabilities.c | 2 +-
 src/qemu/qemu_capabilities.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 1badadbc2..00c00c3c3 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -2390,7 +2390,7 @@ virQEMUCapsGet(virQEMUCapsPtr qemuCaps,
 
 
 bool virQEMUCapsHasPCIMultiBus(virQEMUCapsPtr qemuCaps,
-                               virDomainDefPtr def)
+                               const virDomainDef *def)
 {
     /* x86_64 and i686 support PCI-multibus on all machine types
      * since forever */
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index f0e2e9016..e7d766f80 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -451,7 +451,7 @@ bool virQEMUCapsGet(virQEMUCapsPtr qemuCaps,
                     virQEMUCapsFlags flag);
 
 bool virQEMUCapsHasPCIMultiBus(virQEMUCapsPtr qemuCaps,
-                               virDomainDefPtr def);
+                               const virDomainDef *def);
 
 bool virQEMUCapsSupportsVmport(virQEMUCapsPtr qemuCaps,
                                const virDomainDef *def);
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 1/3] virQEMUCapsHasPCIMultiBus: Fix @def type
Posted by Ján Tomko 7 years, 5 months ago
On Wed, Nov 15, 2017 at 03:40:15PM +0100, Michal Privoznik wrote:
>This function only queries domani @def. It doesn't change it.

s/domani/domain/

>Therefore it should take const pointer.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/qemu/qemu_capabilities.c | 2 +-
> src/qemu/qemu_capabilities.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list