[libvirt] [PATCH 3/3] qemuStateInitialize: Don't leak @memoryBackingPath

Michal Privoznik posted 3 patches 7 years, 5 months ago
[libvirt] [PATCH 3/3] qemuStateInitialize: Don't leak @memoryBackingPath
Posted by Michal Privoznik 7 years, 5 months ago
==899== 39 bytes in 1 blocks are definitely lost in loss record 732 of 1,003
==899==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
==899==    by 0x8B68CE7: vasprintf (in /lib64/libc-2.25.so)
==899==    by 0x55498D2: virVasprintfInternal (virstring.c:708)
==899==    by 0x55499E7: virAsprintfInternal (virstring.c:729)
==899==    by 0x2BECFFF0: qemuGetMemoryBackingBasePath (qemu_conf.c:1757)
==899==    by 0x2BF23225: qemuStateInitialize (qemu_driver.c:893)
==899==    by 0x563073D: virStateInitialize (libvirt.c:770)
==899==    by 0x124CC4: daemonRunStateInit (libvirtd.c:834)
==899==    by 0x55521CD: virThreadHelper (virthread.c:206)
==899==    by 0x88D9686: start_thread (in /lib64/libpthread-2.25.so)
==899==    by 0x8BEAEFE: clone (in /lib64/libc-2.25.so)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 0ec5efbc2..5eae7d24a 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -904,6 +904,7 @@ qemuStateInitialize(bool privileged,
         virFileUpdatePerm(memoryBackingPath,
                           0, S_IXGRP | S_IXOTH) < 0)
         goto error;
+    VIR_FREE(memoryBackingPath);
 
     if (!(qemu_driver->closeCallbacks = virCloseCallbacksNew()))
         goto error;
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 3/3] qemuStateInitialize: Don't leak @memoryBackingPath
Posted by Peter Krempa 7 years, 5 months ago
On Fri, Dec 01, 2017 at 10:09:46 +0100, Michal Privoznik wrote:
> ==899== 39 bytes in 1 blocks are definitely lost in loss record 732 of 1,003
> ==899==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)
> ==899==    by 0x8B68CE7: vasprintf (in /lib64/libc-2.25.so)
> ==899==    by 0x55498D2: virVasprintfInternal (virstring.c:708)
> ==899==    by 0x55499E7: virAsprintfInternal (virstring.c:729)
> ==899==    by 0x2BECFFF0: qemuGetMemoryBackingBasePath (qemu_conf.c:1757)
> ==899==    by 0x2BF23225: qemuStateInitialize (qemu_driver.c:893)
> ==899==    by 0x563073D: virStateInitialize (libvirt.c:770)
> ==899==    by 0x124CC4: daemonRunStateInit (libvirtd.c:834)
> ==899==    by 0x55521CD: virThreadHelper (virthread.c:206)
> ==899==    by 0x88D9686: start_thread (in /lib64/libpthread-2.25.so)
> ==899==    by 0x8BEAEFE: clone (in /lib64/libc-2.25.so)
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/qemu/qemu_driver.c | 1 +
>  1 file changed, 1 insertion(+)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list