[libvirt] [libvirt-php][PATCH 4/5] src: Free @filters array in libvirt_list_all_nwfilters

Michal Privoznik posted 5 patches 7 years, 5 months ago
[libvirt] [libvirt-php][PATCH 4/5] src: Free @filters array in libvirt_list_all_nwfilters
Posted by Michal Privoznik 7 years, 5 months ago
This function calls virConnectListAllNWFilters() which allocates
the return buffer which we never free.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/libvirt-nwfilter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/libvirt-nwfilter.c b/src/libvirt-nwfilter.c
index c1d1d2a..6edaead 100644
--- a/src/libvirt-nwfilter.c
+++ b/src/libvirt-nwfilter.c
@@ -364,6 +364,7 @@ PHP_FUNCTION(libvirt_list_all_nwfilters)
                                 res_nwfilter->nwfilter, 1 TSRMLS_CC);
         VIRT_REGISTER_LIST_RESOURCE(nwfilter);
     }
+    VIR_FREE(filters);
 }
 
 /*
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-php][PATCH 4/5] src: Free @filters array in libvirt_list_all_nwfilters
Posted by Erik Skultety 7 years, 5 months ago
On Mon, Dec 11, 2017 at 07:34:58AM +0100, Michal Privoznik wrote:
> This function calls virConnectListAllNWFilters() which allocates
> the return buffer which we never free.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list