The PROBE macro used in qemuMonitorIOProcess and the VIR_DEBUG message
in qemuMonitorJSONIOProcess create a lot of logging churn when debug
logging is enabled during monitor communication.

The messages logged from the PROBE macro are rather useless since they
are reporting the partial state of receiving the reply from qemu. The
actuall full reply is still logged in qemuMonitorJSONIOProcessLine once
the full message is received.
---
 src/qemu/qemu_monitor.c      | 4 ++--
 src/qemu/qemu_monitor_json.c | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 4db12c512a..046caf001c 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -435,8 +435,8 @@ qemuMonitorIOProcess(qemuMonitorPtr mon)
 # endif
 #endif

-    PROBE(QEMU_MONITOR_IO_PROCESS,
-          "mon=%p buf=%s len=%zu", mon, mon->buffer, mon->bufferOffset);
+    PROBE_QUIET(QEMU_MONITOR_IO_PROCESS, "mon=%p buf=%s len=%zu",
+                mon, mon->buffer, mon->bufferOffset);

     if (mon->json)
         len = qemuMonitorJSONIOProcess(mon,
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index e45868b01f..ea1b8e1f5f 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -259,7 +259,10 @@ int qemuMonitorJSONIOProcess(qemuMonitorPtr mon,
         }
     }

+#if DEBUG_IO
     VIR_DEBUG("Total used %d bytes out of %zd available in buffer", used, len);
+#endif
+
     return used;
 }

-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 12/21/2017 05:16 AM, Peter Krempa wrote:
> The PROBE macro used in qemuMonitorIOProcess and the VIR_DEBUG message
> in qemuMonitorJSONIOProcess create a lot of logging churn when debug
> logging is enabled during monitor communication.
> 
> The messages logged from the PROBE macro are rather useless since they
> are reporting the partial state of receiving the reply from qemu. The
> actuall full reply is still logged in qemuMonitorJSONIOProcessLine once

s/actuall/actual/

> the full message is received.
> ---
>   src/qemu/qemu_monitor.c      | 4 ++--
>   src/qemu/qemu_monitor_json.c | 3 +++
>   2 files changed, 5 insertions(+), 2 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list