[libvirt] [PATCH 2/3] virsh: Offer only persistent domains for autostart

Michal Privoznik posted 3 patches 7 years, 3 months ago
[libvirt] [PATCH 2/3] virsh: Offer only persistent domains for autostart
Posted by Michal Privoznik 7 years, 3 months ago
The 'autostart' command accepts only persistent domains. Make the
completer return only those.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tools/virsh-domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 0f329d6d7..5a0e0c1b2 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -1037,7 +1037,7 @@ static const vshCmdInfo info_autostart[] = {
 };
 
 static const vshCmdOptDef opts_autostart[] = {
-    VIRSH_COMMON_OPT_DOMAIN_FULL(0),
+    VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_PERSISTENT),
     {.name = "disable",
      .type = VSH_OT_BOOL,
      .help = N_("disable autostarting")
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/3] virsh: Offer only persistent domains for autostart
Posted by Martin Kletzander 7 years, 3 months ago
On Thu, Jan 25, 2018 at 03:22:19PM +0100, Michal Privoznik wrote:
>The 'autostart' command accepts only persistent domains. Make the
>completer return only those.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> tools/virsh-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

ACK

>diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
>index 0f329d6d7..5a0e0c1b2 100644
>--- a/tools/virsh-domain.c
>+++ b/tools/virsh-domain.c
>@@ -1037,7 +1037,7 @@ static const vshCmdInfo info_autostart[] = {
> };
>
> static const vshCmdOptDef opts_autostart[] = {
>-    VIRSH_COMMON_OPT_DOMAIN_FULL(0),
>+    VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_PERSISTENT),
>     {.name = "disable",
>      .type = VSH_OT_BOOL,
>      .help = N_("disable autostarting")
>-- 
>2.13.6
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list